Repository navigation
Fix strlen() Stringable __toString coercion (closes #13468) - #13480
Merged
Merged
Conversation
Use VmString::coerceStringBuiltinArg on the VM path and JitNativeString/JitStringBuiltinArg::lowerCoercible on JIT so __toString objects get byte length like trim() family builtins. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 29, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strlen()now usesVmString::coerceStringBuiltinArg(same astrim()family) soStringableobjects returnstrlen((string)$obj).JitStrlencoerces objects viaJitNativeString/JitStringBuiltinArg::lowerCoerciblewhen caller is not strict.php-src reference
ext/standard/string.c—_php_string_argobject coercionVerification
Closes #13468
Made with Cursor