Skip to content

php-in-php: route standalone parse_str through ParseStrRuntime PHP (#13360) - #13361

Merged
PurHur merged 1 commit into
masterfrom
agent/issue-13360-parse-str-standalone-php
Jun 28, 2026
Merged

php-in-php: route standalone parse_str through ParseStrRuntime PHP (#13360)#13361
PurHur merged 1 commit into
masterfrom
agent/issue-13360-parse-str-standalone-php

Conversation

@PurHur

@PurHur PurHur commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Route standalone AOT __compiler_parse_str through ParseStrRuntime + ParseStrJitHelper PHP (same path as embed)
  • Remove standalone-only StringParseStrJit::implement() + emitCompilerParseStr() LLVM (~54 LOC)
  • Context::defineBuiltins standalone init now calls StringParseStr::ensureStandaloneBodies

Closes #13360

php-src reference

  • ext/standard/basic_functions.c — PHP_FUNCTION(parse_str)

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/ParseStrRuntimeShrinkTest.php'
# OK (6 tests, 18 assertions)

make bootstrap-selfhost-vm-driver-execute-probe
# OK

Note: StringParseStrJit sub-helpers (__phpc_parse_str_*) remain LLVM for superglobals/multipart — follow-up migration.

Made with Cursor

@PurHur @cursoragent
php-in-php: route standalone parse_str through ParseStrRuntime PHP (#…
3801c8d 
…13360)

Remove standalone-only __compiler_parse_str LLVM entry from StringParseStrJit;
embed and standalone both use ParseStrRuntime + ParseStrJitHelper bridges.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit df91e26 into master Jun 28, 2026
@PurHur
PurHur deleted the agent/issue-13360-parse-str-standalone-php branch June 28, 2026 22:36
@PurHur PurHur mentioned this pull request Jun 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

php-in-php: route standalone parse_str through ParseStrRuntime PHP — shrink StringParseStrJit (#9295 follow-up)

1 participant

@PurHur