Repository navigation
Language: keyed list destructuring (["a" => $x]) (#1234) - #1317
Merged
Merged
Conversation
String-key array literals before ["key" => $x] destructuring split the compile block for AOT; successor frames lost the array temp until slot values were inherited from the jump predecessor. Simplify the split to a single jump and add a compliance PHPT. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
["a" => $x] = array("a" => 1)) when the compiler splits CFG blocks after string-keyarray()literals (AOT workaround AOT: MiniWebApp native binary CLI execute emits empty stdout (post-link) #764/AOT: Project entry require-as-expression bootstrap (config.php → Router) (#764) #783).Block::getFrame()now inherits predecessor slot values across jumps so the RHS array temp survives the split.splitCfgBlockAfterStringKeyedArray()uses a single jump block instead of an empty hub that dropped live temps.keyed_list_destruct.phptand documents keyed destructuring indocs/unsupported-syntax.md.Test plan
php bin/vm.php -r '["a" => $x] = array("a" => 1); echo $x;'→1(tar-pipe Docker)keyed_list_destruct.phptpasses in full compliance suite (tar-pipe Docker)Closes #1234
Made with Cursor