Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/JIT/Builtin/Type/Object_.php
Original file line number Diff line number Diff line change
Expand Up @@ -1827,7 +1827,9 @@ public function registerClassAlias(string $original, string $alias): bool

$classId = $this->classes[$originalLc];
if (isset($this->externalOnlyClassIds[$classId])) {
return false;
throw new \ValueError(
'class_alias(): Argument #1 ($class) must be a user-defined class name, internal class name given'
);
}

$this->classes[$aliasLc] = $classId;
Expand Down
5 changes: 5 additions & 0 deletions lib/VM/Context.php
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,11 @@ public function registerClassAlias(string $original, string $alias, bool $autolo
}

$entry = $this->classes[$originalLc];
if ($entry->isInternal) {
throw new \ValueError(
'class_alias(): Argument #1 ($class) must be a user-defined class name, internal class name given'
);
}
$this->classes[$aliasLc] = $entry;
$this->classAliases[$aliasLc] = $originalLc;
if ($entry->isEnum) {
Expand Down
15 changes: 15 additions & 0 deletions test/compliance/cases/stdlib/class_alias_internal.phpt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
--TEST--
stdlib class_alias() rejects internal class targets (#9211, Zend/zend_builtin_functions.c)
--FILE--
<?php
try {
class_alias('stdClass', 'SC9211');
echo "alias ok\n";
} catch (Throwable $e) {
echo get_class($e), ': ', $e->getMessage(), "\n";
}
var_export(class_exists('SC9211', false));
echo "\n";
--EXPECT--
ValueError: class_alias(): Argument #1 ($class) must be a user-defined class name, internal class name given
false
11 changes: 11 additions & 0 deletions test/repro/maintainer_gap_class_alias_internal.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php
declare(strict_types=1);

try {
class_alias('stdClass', 'SC2');
echo "alias ok\n";
} catch (Throwable $e) {
echo get_class($e), ': ', $e->getMessage(), "\n";
}
var_export(class_exists('SC2', false));
echo "\n";