Stdlib: session_* builtins with file-backed $_SESSION (VM) - #1294
Merged
Merged
Conversation
Add session_start, session_id, session_name, session_destroy, session_write_close, and session_regenerate_id for North Star web/self-host stdlib coverage. Sessions persist via serialized $_SESSION files under PHP_COMPILER_SESSION_DIR or sys temp; JIT deferred as VM-only. Closes #64. Closes #1182. Closes #1183. Closes #1184. Closes #1185. Closes #1186. Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate capability matrix and stdlib JIT audit after merge with preg_replace_callback on master. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_start(),session_id(),session_name(),session_destroy(),session_write_close(), andsession_regenerate_id()for VM modeVmSessionfile driver: serialized$_SESSIONunderPHP_COMPILER_SESSION_DIRorsys_get_temp_dir()/phpc_sessionsSet-Cookievia existingResponseContext/SetcookieLine; resume from$_COOKIEon next requestFUNCCALL_EXEC_NORETURNwithoutreturnVar)Closes #64
Closes #1182
Closes #1183
Closes #1184
Closes #1185
Closes #1186
Test plan
SessionBuiltinTest— two-request persistence, destroy, regenerate idtest/compliance/cases/stdlib/session*.phpt— VM PHPT smokephp script/capability-matrix.php --check./script/ci-fast.sh --filter SessionBuiltinTest(Docker tar harness)Made with Cursor