Repository navigation
Fix 3-array array_intersect_ukey and ArrayObject getIteratorClass inline args (#5644, #10778) - #12687
Merged
Merged
Conversation
… getter. Collect all sibling inline array producers before multi-array ukey calls, skip void setIteratorClass when mapping hoisted MethodCall preludes to var_export, and require a true nested array chain before treating multiple Array_ producers as one arg. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Array_producers forarray_intersect_ukey($a, $b, $c, $callback)instead of stopping after two.setIteratorClass()when resolving hoistedMethodCallpreludes sovar_export($ao->getIteratorClass(), true)receives the getter result.Test plan
vendor/bin/phpunit --filter 'array_udiff_family|ArrayIntersectUkeyThreeArrayTest|arrayobject_getiterator_after_set|ArrayObjectGetIteratorAfterSetTest'vendor/bin/phpunit --filter testArrayMapDualInlineArrayLiteralUsesAllSlots test/unit/InlineCallArgProducerSlotTest.phpMade with Cursor