Repository navigation
Fix examples web smoke: ServeCompileCache constant mutation (#12040) - #12050
Merged
Merged
Conversation
Cached Block constants were shared by reference into frame scope; builtins coerced them in place so the second phpc serve request queued an empty header and truncated HTTP bodies. Clone constants per run and ignore blank header lines. Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServeCompileCachereuses compiledBlockinstances acrossphpc serverequests, butBlock::getFrame()placed compile-time constants into frame scope by reference. Builtins such asheader()coerce arguments in place, so the cached literal forContent-Type: …became""on the second request.DevServer::respond()wrote an empty extra header line (\r\nonly), terminating HTTP headers early;Content-Lengthno longer matched the body and curl truncated responses (002-StaticWebGET /missingWorld).Variablecells per run viascopeConstantVariable(); ignore blankheader()/extraHeaderslines defensively.PHP implementation:
lib/Block.php(scope setup),lib/Web/ResponseContext.php,lib/Web/DevServer.php.Verification
Closes #12040
Made with Cursor