php-in-php: route preg_* JIT embed through PregJitHelper (#9542) - #12034
Merged
Merged
Conversation
…olith (#9542) Embed JIT/AOT now bridges __compiler_preg_* to VmPregNative via PregJitHelper; StringPregMatchJit is a thin dispatcher (68 LOC) with the pcre2 LLVM body quarantined to StringPregMatchStandaloneLlvm for standalone AOT only. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/standard/PregJitHelper.phpas SSOT overVmPregNativefor embed JIT/AOT preg builtinslib/JIT/Builtin/PregMatchRuntime.phpwith LLVM bridges to compiled PHP helpersStringPregMatchJit.phpto a 68-line dispatcher; quarantine pcre2 LLVM toStringPregMatchStandaloneLlvm.php(standalone AOT only)preg_replace_callbackembed still uses a thin LLVM slice from standalone until callback ABI is PHP-hostedCloses #9542
LLVM shrink
StringPregMatchJit.php(embed dispatch)StringPregMatchStandaloneLlvm.php(standalone only)php-src reference
ext/pcre/php_pcre.c— behavior via existingVmPregNative/VmPregMatchesVerification
Made with Cursor