Repository navigation
Fix filter_var() nested inline options call-arg slot wiring (#12007) - #12014
Merged
Merged
Conversation
When php-cfg hoists ConstFetch plus a nested Array_ chain for the third argument, matchInlineCallArgProducer mapped the inner array to the filter slot. Map the leading constant to the filter argument and the outer array to the options argument instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matchInlineCallArgProducerwhen php-cfg hoistsConstFetch+ nestedArray_preludes forfilter_var()third argument (e.g.['options' => ['regexp' => '/^a/']]).$filteroperand; now the leading constant maps to the filter arg and the outer array to options.ext/filter/filter.c—php_filter_var(),php_filter_parse_args().Verification
Closes #12007
Made with Cursor