php-in-php: route IteratorHelper foreach LLVM through VmIteratorForeach PHP (#10080) - #11652
Merged
Merged
Conversation
…ch PHP (#10080) Move hashtable/SplObjectStorage/WeakMap foreach lowering from lib/JIT/ IteratorHelper.php (725 lines) into lib/VM/VmIteratorForeach.php SSOT; IteratorHelper is now a thin trampoline (54 lines). Spine + shrink guard. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/issue-10080-iterator-helper-php
branch
from
June 25, 2026 13:51
2bc2b3b to
008dd37
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/IteratorHelper.phpintolib/VM/VmIteratorForeach.php(PHP SSOT, same pattern as php-in-php: JIT IteratorProtocolHelper — route Iterator foreach LLVM through VmIterator PHP not ~335-line monolith (#1492) #10240 IteratorProtocolHelper → VmIteratorProtocol).IteratorHelper.phpshrinks 725 → 54 lines (thin trampoline only).VmIteratorForeach.php; shrink guard inIteratorHelperRuntimeShrinkTest.php-src reference
Zend/zend_execute.c—ZEND_FE_FETCH_Rarray/hashtable branchLLVM shrink
lib/JIT/IteratorHelper.phplib/VM/VmIteratorForeach.phpNo new
runtime/*.csymbols.Verification
Closes #10080
Made with Cursor