Repository navigation
php-in-php: route get_class class-id LLVM through GetClassJitHelper (#10222) - #11477
Merged
Merged
Conversation
…10222). Replace ReflectionBuiltinHelper's per-class LLVM select chain with a compiled PHP helper and thin __phpc_class_name_from_id bridge. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetClassJitHelper+GetClassRuntimethin bridge (__phpc_class_name_from_id)ReflectionBuiltinHelper::classNameFromIdno longer emits per-class LLVM select chain (~14 LOC removed)Closes #10222 (partial — literal reflection helpers already PHP at compile time; runtime
get_classpath migrated)php-src reference
ext/standard/basic_functions.c—PHP_FUNCTION(get_class)Zend/zend_builtin_functions.c—zend_get_object_classnameLLVM shrink
ReflectionBuiltinHelper.php: 336 → 332 lines; removedallClassNamesById()select loop inclassNameFromIdVerification
./script/ci-fast.sh— greenMade with Cursor