Stdlib: date_parse() unparsed hour/minute/second — false not 0 (#11068) - #11075
Merged
Merged
Conversation
date_parse('2024-01-01') must leave hour/minute/second/fraction as boolean false when absent from the input, matching php-src parsedate.c — not midnight zeros from localtime expansion.
Closes #11068
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
date_parse('2024-01-01')now leaveshour/minute/second/fractionas booleanfalsewhen absent from the input, matching php-srcext/standard/parsedate.cparseDateComponents()path avoids expanding date-only strings throughlocaltime()(which always produced midnight zeros)php-src reference
ext/standard/parsedate.c— field initialization for unparsed componentsext/standard/VmDateTimeNative.php(parseDateComponents)Verification
Closes #11068
Made with Cursor