Repository navigation
Fix ArrayObject getIteratorClass() after void setIteratorClass() (#10778) - #10800
Merged
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MethodCallstatement producers from inline call-arg matching soecho var_export($ao->getIteratorClass(), true)binds the getter, not a preceding voidsetIteratorClass()(Stdlib: ArrayObject::getIteratorClass() returns null after void setIteratorClass() in expression (ext/spl/spl_array.c) #10778).ArrayObject::setIteratorClass()now validates and persists even whenreturnVaris null (void call path).php-src reference:
ext/spl/spl_array.c—spl_array_setIteratorClass/spl_array_getIteratorClassPHP implementation:
lib/Compiler.php(filterDeadVoidStatementMethodCallProducers),ext/spl/ArrayObjectBuiltin.phpCloses #10778
Test plan
Output (VM):
(both repros exit 0)
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./vendor/bin/phpunit --filter arrayobject_getiterator_after_set'OK (2 tests, 2 assertions)
Made with Cursor