Repository navigation
php-in-php: JIT IncludePathRuntime → IncludePathJitHelper PHP (#9245) - #10789
Merged
Merged
Conversation
Replace phpc_include_path_* LLVM globals and libc resolve loop with compiled PHP stack/resolve helpers; VmIncludePath and VmFs delegate to shared storage. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpc_include_path_*LLVM globals + ~350-line libcaccess/realpathresolve loop inIncludePathRuntime.phpwith thin bridges into compiled PHP helpers.IncludePathJitHelper(NUL-delimited stack) andIncludePathResolveJitHelper(Zend parity viaScriptStack/VmStatPath; JIT path usesis_file/realpath).VmIncludePathandVmFs::resolveIncludePath()delegate to the helpers so VM + JIT share storage.Closes #9245
C runtime shrink
lib/JIT/Builtin/IncludePathRuntime.phpphpc_include_path_depth/phpc_include_path_current/phpc_include_path_stackLLVM globalsimplementGlobals,implementInitDefaultPath, full LLVMimplementResolve(access/realpath/memcpy loop)access,realpath,strchr,memcpyfor include_pathphp-src reference
ext/standard/basic_functions.c—php_get_include_path/php_set_include_pathext/standard/streams.c—php_stream_resolve_include_pathVerification
Made with Cursor