Repository navigation
Fix nested substr(sprintf()) losing inner return (#10673) - #10685
Merged
Merged
Conversation
Teach sibling multi-arg inline producer matching to allow a UnaryMinus prelude between nested FuncCalls so sprintf feeds substr arg 0 while -N feeds arg 1; add repro, compliance guard, and compile-slot unit test. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sprintf()feedssubstr()arg 0 and aUnaryMinusprelude feeds arg 1 (substr(sprintf('%o', $mode), -4)).isSiblingMultiArgFuncCallProducerto recognize FuncCall + unary prelude + multi-arg consumer pattern (Stdlib: nested substr(sprintf()) — inner string lost, wrong slice (ext/standard/string.c) #10673, related Regression: var_export($nested_builtin, true) returns NULL — inline call arg not evaluated (ext/standard/var.c) #10373/Regression: nested string/scalar-return builtin in call argument evaluates to null (extends #9547, Zend/zend_execute.c) #10495).InlineCallArgProducerSlotTestcompile-slot assertion.php-src reference
ext/standard/string.c—php_substr/php_sprintfZend/zend_execute.c— nested call temporariesPHP implementation
lib/Compiler.php—siblingMultiArgFuncCallProducerTargetArgIndex, unary-prelude sibling producer matchingVerification
Closes #10673
Made with Cursor