Fix number_format() enum TypeError arg indices (#8795)

[PurHur]

Summary

• Fix off-by-one TypeError argument numbers for number_format() $decimal_separator and $thousands_separator when enum cases are passed (VM + JIT).
• Root cause: VmString / JitStringBuiltinArg use 0-based arg indices (+1 in messages) while VmMath / JitIntdiv use 1-based indices — string params were incorrectly using the int convention.
• Add maintainer repro test/repro/maintainer_number_format_enum_typeerror.php.

php-src reference

• php/php-src ext/standard/number_format.c — Z_PARAM_STR TypeError arg numbers

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php test/repro/maintainer_number_format_enum_typeerror.php
php bin/jit.php test/repro/maintainer_number_format_enum_typeerror.php
php vendor/bin/phpunit --filter number_format_enum
'

Output:

decimals: number_format(): Argument #2 ($decimals) must be of type int, E given
decimal_separator: number_format(): Argument #3 ($decimal_separator) must be of type ?string, E given
OK (4 tests, 4 assertions)

Closes #8795

Made with Cursor