php-in-php: JIT InstanceOfHelper routes dynamic RHS through InstanceOfJitHelper (#10078) - #10609
Merged
Merged
Conversation
…HP (#10078). Move native-type and value-box RHS dispatch from inline LLVM to shared VM PHP helpers with JitVmHelperLink bridges, matching the Coalesce/InOperator shrink pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/VM/InstanceOfJitHelper.phpas SSOT for dynamicinstanceofRHS guards (jitRhsTypeIsInvalidClass,valueBoxRhsKind).lib/JIT/InstanceOfHelper.phpto call the PHP helper at compile time and route value-box RHS dispatch throughJitVmHelperLink(__instanceof__valueBoxRhsKindbridge).InstanceOfClassName; add spine +InstanceOfRuntimeShrinkTestguard.php-src reference
Zend/zend_execute.c—ZEND_INSTANCEOFclass operand must be string or objectPHP implementation
lib/VM/InstanceOfJitHelper.php— type guard SSOTlib/JIT/InstanceOfHelper.php— thin LLVM trampoline + class-id/name matching loopsVerification
Closes #10078
Made with Cursor