Repository navigation
Fix nested scalar-return builtin in call argument evaluates to null (#10495) - #10582
Merged
Merged
Conversation
When php-cfg hoists trailing literal ConstFetch nodes between nested FuncCalls (e.g. var_export(get_debug_type(null), true)), wire the inner FUNCCALL_EXEC_RETURN slot to the outer TYPE_ARG_SEND instead of a dead temp. Co-authored-by: Cursor <cursoragent@cursor.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConstFetchbetween nestedFuncCallnodes (e.g.var_export(get_debug_type(null), true)).isNestedCallArgProducerSeparatedByConsumerLiteralPreludes()so innerFUNCCALL_EXEC_RETURNslots wire to outerTYPE_ARG_SENDinstead of dead temps.get_debug_type,gettype,json_encode,get_class.Closes #10495
php-src / PHP-in-PHP
Zend/zend_execute.cnested call arg evaluationlib/Compiler.php— inline call-arg producer matchingVerification
Results (2026-06-22):
'null','NULL','null','stdClass'(wasNULLfor nested calls)InlineCallArgProducerSlotTest::testVarExportNestedScalarBuiltinUsesFuncCallProducerSlot— OKnested_string_builtin_arg.phptcompliance — OK (VM + JIT matrix)Made with Cursor