Repository navigation
php-in-php: route TYPE_FROM_CALLABLE JIT through VmFromCallable PHP (#10272) - #10454
Merged
Merged
Conversation
…10272) Move FCC lowering SSOT from FromCallableHelper (~214 lines) into lib/VM/VmFromCallable.php aligned with ClosureSupport; shrink JIT helper to a thin trampoline. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/FromCallableHelper.php(~214 lines) intolib/VM/VmFromCallable.php, aligned withClosureSupport::fromCallable()semantics (Zendzend_closures.c/zend_compile.c).FromCallableHelperto a 22-line trampoline delegating toVmFromCallable.FromCallableRuntimeShrinkTest+ spine/bundle entries for self-host.Lines removed from JIT helper: 214 → 22 (−192 lines, ~90% shrink). Logic now lives in
lib/VM/VmFromCallable.php(PHP SSOT).Closes #10272
Verification
Made with Cursor