Repository navigation
Fix static closure bindTo fatal + restore Error parity (#4613) - #10425
Merged
Merged
Conversation
…#4613). Use func->class->value when building return-type labels so methods with :class return types (e.g. make(): Closure) no longer fatal; static Closure::bindTo/bind now emit Zend Error as expected. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VM::returnTypeCallableName()to readfunc->class->valueinstead of concatenating thePHPCfg\Operand\Literalobject — unblocks methods with class return types such asmake(): Closure.Closure::bindTo()/Closure::bind()with$thisnow reach the existingClosureSupportguard and throwError: Cannot bind static closure to objecton VM and JIT (was fatal before bind path ran).catch (Error)without$eto avoid unrelated catch-slot warning noise in output comparison.php-src reference
Zend/zend_closures.c—zend_closure_bind()static-closure guardPHP implementation
lib/VM.php—returnTypeCallableName()lib/VM/ClosureSupport.php— existing static closure Error (unchanged)Verification
Output:
Closes #4613
Made with Cursor