Fix manual Throwable getTrace() empty on construct (#9905) - #10297
Merged
Merged
Conversation
Snapshot the constructing call frame when Throwable::__construct runs so getTrace() returns array(1) inside user functions like Zend; throw still overwrites via captureOnThrow and clears the manual snapshot on rethrow. Co-authored-by: Cursor <cursoragent@cursor.com>
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Throwable::__constructasmanualConstructTracesogetTrace()returnsarray(1)when an exception is constructed inside a user function without being thrown (Zendzend_exceptions.cparity).captureOnThrowclears the manual snapshot and still fillstraceon throw; rethrow with existing trace unchanged.ExceptionGetTraceresolves manual snapshot whentraceproperty is still empty.Closes #9905
php-src reference
Zend/zend_exceptions.c— trace capture on manual construct vs throwPHP implementation
lib/VM/ExceptionTrace.php—captureOnManualConstruct,resolveTraceVariablelib/VM/ExceptionSupport.php— hook construct pathslib/VM/Builtin/ExceptionGetTrace.php— resolve snapshotlib/VM/ObjectEntry.php—manualConstructTracefieldVerification
Output (VM after fix):
Made with Cursor