Repository navigation
php-in-php: JIT ScalarDimFetchHelper → ScalarDimFetchJitHelper PHP (#10271) - #10282
Merged
Merged
Conversation
…hJitHelper (#10271) Move ZEND_FETCH_DIM_R scalar warning message SSOT into VM PHP and compile it for JIT/AOT via ScalarDimFetchRuntime, shrinking ScalarDimFetchHelper to a thin trampoline that no longer emits inline __compiler_trigger_error IR. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZEND_FETCH_DIM_RJIT warnings through compiledScalarDimFetchJitHelperPHP viaScalarDimFetchRuntimeinstead of inline LLVM__compiler_trigger_errorIR inScalarDimFetchHelper.ErrorReporter::arrayOffsetOnNonContainerMessage()as VM/JIT message SSOT (php-src:Zend/zend_execute.c).lib/JIT/ScalarDimFetchHelper.phpfrom 44 → 27 lines (removedemitArrayOffsetWarning()LLVM path).C runtime shrink
No new
runtime/*.clogic. Removed ~17 lines of inline LLVM warning emission fromScalarDimFetchHelper.php.Verification
Closes #10271
Made with Cursor