Repository navigation
Close stale #10203: enum spaceship maintainer repro guard - #10207
Merged
Merged
Conversation
Regression was already fixed on master; wire VM/JIT maintainer repro into PHPUnit so stale #10203 filing stays closed. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master(VM + JIT returnint(1)for all three maintainer probe lines matching Zend).EnumSpaceshipMaintainerReproTestto guardtest/repro/maintainer_spaceship_enum.phpon VM and JIT so the stale regression filing stays closed.Closes #10203
php-src reference
Zend/zend_enum.c—zend_compare_enum(enum<=>is not backing-scalar order; different cases / enum-vs-non-enum return1, identical case0)Verification
Lane A audit note
Other lane-A language queue items checked this run (#9621 instanceof/is_a, #10029 static enum property default, #9684/9951/10062/10131) — all green on current
master; recommend closing those stale filings separately.Made with Cursor