Compliance: promoted public private(set) asymmetric visibility (#10001)

[PurHur]

Summary

• Closes Language: asymmetric visibility on constructor-promoted properties — parse fails (PHP 8.4, Zend/zend_compile.c) #10001 — promoted public private(set) constructor parameters were already supported via AsymmetricVisibilityRewriter (Language: asymmetric visibility (public private(set)) — PHP 8.4 parse + runtime (Zend/zend_compile.c) #9724) and AsymmetricVisibilityCompileCheck (Regression: constructor-promoted asymmetric visibility public private(set) — compile fatal (re-#4690) #6981).
• Adds the issue repro as a VM+JIT compliance guard: test/compliance/cases/language/asymmetric_promoted_ctor.phpt.

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php vendor/bin/phpunit --filter asymmetric_promoted_ctor
php bin/vm.php test/repro/asymmetric_visibility_promoted_ctor.php
'

Output:

OK (2 tests, 2 assertions)  # VM + JIT compliance
alice
Cannot modify private(set) property User::$name from global scope

Inline repro (public private(set) int $x = 1, default overridden to 2):

2
Error: Cannot modify private(set) property C::$x from global scope

Test plan

• phpunit --filter asymmetric_promoted_ctor (VM + JIT)
• Issue repro read + private(set) write guard on VM/JIT

Made with Cursor