php-in-php: JIT StringEnvLocal — route putenv/getenv overlay through VmEnv PHP not ~440-line LLVM (#1492)

[PurHur]

Category

php-in-php · php-src-strict

Problem

Process-local environment overlay for putenv() / getenv() is implemented in PHP (ext/standard/VmEnv.php), but JIT/AOT still link lib/JIT/Builtin/StringEnvLocal.php (~440 lines) reimplementing phpc_env_local_* hashtable logic in LLVM (replaces deleted lib/AOT/runtime/phpc_env_local.c).

CGI/superglobal refresh and self-host probes depend on consistent env semantics across VM/JIT/AOT.

php-src reference

• php/php-src ext/standard/basic_functions.c — PHP_FUNCTION(putenv), PHP_FUNCTION(getenv)
• php/php-src main/php_variables.c — EG(env) overlay

Repro

Save as test/repro/maintainer_putenv_getenv_jit.php:

<?php
putenv('PHPC_TEST_ENV=1');
var_export(getenv('PHPC_TEST_ENV'));
echo "\n";
putenv('PHPC_TEST_ENV');
var_export(getenv('PHPC_TEST_ENV'));
echo "\n";
putenv('PHPC_TEST_ENV=2');
var_export(getenv('PHPC_TEST_ENV'));
echo "\n";

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php test/repro/maintainer_putenv_getenv_jit.php
php bin/jit.php test/repro/maintainer_putenv_getenv_jit.php
'

Step	Zend	VM today	JIT today (gap)
set + get	'1'	OK	must match after migration
unset via putenv('NAME')	false	OK	must match
reset	'2'	OK	must match

Scope

Path	Work
ext/standard/EnvLocalJitHelper.php (new)	Bridge calling VmEnv overlay SSOT
lib/JIT/Builtin/StringEnvLocal.php	Thin ABI; delete 256-entry LLVM table
lib/JIT/Builtin/JitEnv.php (if present)	Wire helper
Tests	test/compliance/cases/stdlib/putenv_getenv_jit.phpt

Done when

• JIT/AOT repro matches VM/Zend
• StringEnvLocal.php bridge-only (−350+ LLVM lines)
• No resurrection of phpc_env_local.c
• ./script/ci-fast.sh --filter putenv_getenv green

Related

• Stdlib: getenv() — local_only second argument (ext/standard/basic_functions.c parity) #3710, php-in-php: local environment table — delete phpc_env_local.c (~156 lines), putenv/getenv in ext/standard #5345 env overlay · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: PHP Runtime → PHP — batch (issues #9860, #9814)

[PurHur]

Blocked on nested JIT compile of overlay storage.

Attempted: unify standalone StringGetenv through GetenvJitHelper + thin EnvLocalJitHelper bridges (delete StringEnvLocal LLVM table).

Failure: NestedJitCompileScope compiling GetenvJitHelper.php throws LogicException: Unknown array write op: StaticPropertyFetch — static $local array in helper cannot lower in standalone AOT link today.

Standalone path still requires StringGetenvLibcBridge + StringEnvLocal LLVM globals (phpc_env_local_entries); embed path already uses GetenvJitHelper (#9092).

Next: module-local PHP static storage for compiled helpers (shared HashTableJitExport / JIT static property support) OR shrink StringGetenvAll::emitLocalOverlay LLVM separately once overlay table is exportable.

#9860 merged in this run; #9814 handed off.

[PurHur]

claim: PHP Runtime → PHP — batch (issues #9815 StreamSyncJit, #9814 StringEnvLocal)

[PurHur]

Merged via #11165.

JIT embed path: deleted StringEnvLocal LLVM overlay for lookup/register; EnvLocalRuntime + EnvLocalJitHelper route through GetenvJitHelper PHP SSOT. StringGetenvAll overlay merge via compiled helper (−~90 LLVM lines).

Standalone: EnvLocalStandaloneLlvm quarantined until static overlay storage compiles in native nested link (issue blocker persists for full deletion).

Verification:

vendor/bin/phpunit --filter EnvLocalRuntimeShrinkTest  # OK
php bin/vm.php test/repro/maintainer_putenv_getenv_jit.php  # 1 / false / 2
php bin/jit.php test/repro/maintainer_putenv_getenv_jit.php  # 1 / false / 2