php-in-php: JIT StringStrtokJit — route strtok() through VmString PHP not ~480-line phpc_strtok LLVM (#1492)

[PurHur]

Category

php-in-php · php-src-strict runtime semantics

Problem

strtok() VM semantics live in ext/standard/strtok.php / VmString::strtok(), but JIT/AOT still link lib/JIT/Builtin/StringStrtokJit.php (~480 lines) emitting phpc_strtok / __phpc_strtok_* LLVM with a fixed 64KiB global buffer — duplicating PHP logic and blocking C-runtime shrink.

php-src reference

• php/php-src ext/standard/string.c — PHP_FUNCTION(strtok), reentrant state
• Former C: lib/AOT/runtime/phpc_strtok.c (removed; LLVM reimplemented in PHP repo)

Repro (parity guard)

Save as test/repro/maintainer_strtok_jit_parity.php:

<?php
$s = "a,b,c";
echo strtok($s, ","), "\n";
echo strtok(","), "\n";
echo strtok(","), "\n";
echo var_export(strtok(","), true), "\n";
strtok("x:y", ":");
echo strtok(":"), "\n";

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php test/repro/maintainer_strtok_jit_parity.php
php bin/vm.php test/repro/maintainer_strtok_jit_parity.php
php bin/jit.php test/repro/maintainer_strtok_jit_parity.php
'

VM today matches Zend; JIT/AOT must call the same PHP helper after migration (no second strtok walk in LLVM).

Scope (this repo)

Path	Work
ext/standard/StrtokJitHelper.php (new) or extend JitStrtok.php	Compiled PHP SSOT callable from JIT bridge
lib/JIT/Builtin/StringStrtokJit.php	Thin ABI: delegate to helper; delete buffer/table LLVM
lib/JIT/Builtin/JitStrtok.php	Wire bridge
AOT standalone link	Prefer compiled helper over phpc_strtok symbol
Tests	test/compliance/cases/stdlib/strtok_jit.phpt

Done when

• JIT + AOT repro output matches VM/Zend
• StringStrtokJit.php shrinks to bridge-only (target: −400+ LLVM lines)
• No new symbols in lib/AOT/runtime/*.c
• ./script/ci-fast.sh --filter strtok green (or targeted PHPUnit filter above)

Related

• php-in-php: strtok() — delete phpc_strtok.c (~134 lines), VM+JIT from ext/standard/VmString.php #6111 (closed VM strtok) · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492 PHP-in-PHP north star

[PurHur]

claim: PHP Runtime → PHP — starting this run.

[PurHur]

Merged via #9825.

PHP path: ext/standard/StrtokJitHelper.php → VmString::strtok() SSOT; lib/JIT/Builtin/StringStrtok.php thin ABI bridges; StringStrtokJit.php now 15-line shim.

C/LLVM shrink: −464 lines from StringStrtokJit.php (deleted __phpc_strtok_buf/len/last globals + buffer/table LLVM walk). No new runtime/*.c symbols.

Verification: VM/JIT repro test/repro/maintainer_strtok_jit_parity.php matches; StrtokJitRuntimeShrinkTest, StringStrtokRuntimeStandaloneTest, StrtokJITTest, StrtokVMTest green; spine sync OK.