Regression: in_array()/array_search() enum needle — TypeError null haystack (re-#8796, ext/standard/array.c)

[PurHur]

Category

stdlib · php-src-strict · regression

Problem

#8796 closed with enum needle/haystack parity, but VM regressed: in_array(E::A, [E::A, E::B]) and related calls now fatal with haystack null instead of returning booleans/keys. Zend still returns true / 0 as expected.

php-src reference

• php/php-src ext/standard/array.c — php_in_array, php_array_search
• php/php-src Zend/zend_enum.c — enum case comparison in arrays

Repro

test/repro/maintainer_in_array_search_enum.php:

<?php
declare(strict_types=1);

enum E: int { case A = 1; case B = 2; }

var_export(in_array(E::A, [E::A, E::B]));
var_export(in_array(E::A, [E::A, E::B], true));
var_export(array_search(E::A, [E::A, E::B]));
var_export(in_array(1, [E::A], false));

./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_in_array_search_enum.php'
# Zend: true / true / 0 / true

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_in_array_search_enum.php'
# VM: Fatal TypeError haystack null on first in_array()

Call	Zend	VM today
in_array(E::A, [E::A, E::B])	true	Fatal
in_array(E::A, ..., true)	true	(not reached)
array_search(E::A, ...)	0	(not reached)
in_array(1, [E::A], false)	true (loose backing)	(not reached)

Coordinate with #8898 for loose scalar-vs-case semantics once haystack wiring is restored.

Scope (this repo)

Area	Path
Builtins	ext/standard/in_array.php, array_search.php, shared array search helpers
Enum compare	VM enum zval path — likely broken arg slot / null haystack after #9676 scalar regression

Done when

• Full repro green under VM
• Strict + loose enum cases covered
• ./script/ci-fast.sh --filter InArray or compliance PHPT guard

Related

• Regression: in_array()/array_search() — enum needle no longer matches enum haystack (re-#5592/#5668, array.c) #8796 (closed) · Stdlib: in_array()/array_search() loose mode matches enum cases via backing coercion (ext/standard/array.c) #8898 · Regression: backed enum E::Case yields backing scalars not enum objects (re-#9111, Zend/zend_enum.c) #9676 · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Verified on master: repro and in_array_search_enum_loose.phpt are green (VM matches compliance EXPECT). Haystack-null regression appears already fixed. Handing off — picking #9700 instead.

[PurHur]

claim: cursor-agent-lane-a — starting this run (compiler inline-array haystack arg binding for in_array/array_search enum needle; lib/ lowering not ext/standard semantics)

[PurHur]

claim: cursor-agent-lane-a — batch (issues #9702, #9390)

[PurHur]

Merged via #11983.

Verification:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_in_array_search_enum.php'
# true / true / 0 / false
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && ./vendor/bin/phpunit --filter in_array_search_enum'
# OK (2 tests)