php-in-php: JIT SpaceshipCompareJit — route <=> through CompareJitHelper PHP not ~1.2k-line LLVM (#1492)

[PurHur]

Category

php-in-php · language · compile-pipeline migration (#1492)

Problem

<=> (spaceship) lowering for JIT/AOT lives in lib/JIT/Builtin/SpaceshipCompareJit.php (~1,190 lines of LLVM type dispatch, hashtable walks, object compares). Scalar semantics already have a PHP SSOT in lib/VM/CompareJitHelper.php via SpaceshipRuntime, but object/hashtable paths remain duplicated in LLVM.

This blocks shrinking the JIT emit surface and keeps compare edge cases (enum objects, NAN, arrays) divergent from VM — see #9288 (enum <=> order regression).

php-src reference

• php/php-src Zend/zend_operators.c — compare_function / spaceship
• php/php-src Zend/zend_enum.c — enum compare rules

Repro (behavior anchor — enum order)

test/repro/enum_relational.php:

<?php
enum E: int { case A = 1; case B = 2; }
var_export(E::A <=> E::B);

./script/docker-exec.sh -- php bin/vm.php test/repro/enum_relational.php   # today: -1 (wrong)
./script/docker-exec.sh -- php test/repro/enum_relational.php                # Zend: 1

Migration done-when is JIT calls PHP helper; enum ordering fix may land here or via #9288 — both must be green before close.

Scope (this repo)

Layer	Path
LLVM today	lib/JIT/Builtin/SpaceshipCompareJit.php, lib/JIT/Builtin/SpaceshipRuntime.php
PHP SSOT	lib/VM/CompareJitHelper.php, shared with VM <=>
Delete/shrink	Remove scalar/object compare LLVM once MCJIT/AOT route through PHP trampoline
Tests	Existing spaceship compliance + enum_relational.php guard

Done when

• JIT/AOT <=> on scalars/enums/arrays/objects calls CompareJitHelper (or thin LLVM trampoline only)
• SpaceshipCompareJit.php reduced to link stubs or deleted; no duplicated compare tables in LLVM
• ./script/ci-fast.sh --filter Spaceship green; enum relational repro matches Zend
• PR notes lines removed from SpaceshipCompareJit.php (target: majority of ~1.2k LLVM)

Related

• Regression: enum relational operators — < and <=> order inverted vs Zend (re-#9016, zend_enum.c) #9288 · php-in-php: JIT SpaceshipCompareJit — route <=> through VM compare PHP not ~1.2k-line LLVM (#1492) #9381 · php-in-php: spaceship (<=>) — delete phpc_spaceship.c, VM+JIT from lib/ #5185 · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: cursor-agent-lane-c — batch (issues #9476); lane C has zero non-stdlib/non-php-in-php tickets — taking php-in-php JIT migration per #1492 compiler pillar

[PurHur]

claim released: cursor-agent-lane-c — enum spaceship VM parity already green on master (enum_spaceship.phpt); full LLVM→CompareJitHelper migration (#9476 scope ~1.2k lines) deferred — lane C queue has no smaller non-php-in-php tickets

[PurHur]

claim released: cursor-agent-lane-c — batch item #9476 deferred; scalar CompareJitHelper routing already green (#9381). Remaining work is object/hashtable LLVM in SpaceshipCompareJit.php (~900 lines) — needs CompareJitHelper object/array bridges or VM trampoline; too large for same run as #10109 shrink (#11299).

[PurHur]

claim: cursor-agent-lane-c — batch (issues #9476); route object/hashtable spaceship JIT through CompareJitHelper PHP bridges (#1492 pillar 5)

[PurHur]

Merged #11552

JIT embed now routes __object__compareSpaceship / __hashtable__compareSpaceship through compiled CompareJitHelper::objectSpaceship / hashtableSpaceship (thin LLVM bridges). Standalone AOT still uses LLVM walkers — follow-up to extract ~350 lines to standalone module.

Verification:

• vendor/bin/phpunit test/unit/SpaceshipCompareJitHelperTest.php — OK (5 tests)
• php bin/jit.php test/compliance/cases/language/enum_relational_operators.phpt — Zend parity
• make bootstrap-selfhost-vm-driver-execute-probe — OK

claim released: cursor-agent-lane-c — #9476 embed path shipped; standalone LLVM extraction remains open on this issue