php-in-php: JIT StringHttpBuildQuery — route http_build_query() through VmHttpBuildQuery PHP not ~380-line LLVM (#1492)

[PurHur]

Category

php-in-php · php-src-strict

Problem

http_build_query() VM handler (ext/standard/http_build_query.php) already builds query strings via VmHttpBuildQuery. JIT/AOT still emit a separate lib/JIT/Builtin/StringHttpBuildQuery.php LLVM walker (__compiler_http_build_query, ~381 lines) that re-implements nesting, PHP_QUERY_RFC1738/RFC3986, and bracket encoding.

Enum encoding parity is tracked in #8733; this issue is the LLVM duplication migration so JIT fixes land once in PHP.

php-src reference

• php/php-src ext/standard/http.c — php_url_encode_hash_ex, http_build_query
• php/php-src ext/standard/basic_functions.stub.php — http_build_query signature

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php -r "
\$data = [\"a\" => 1, \"b\" => [\"c\" => 2, \"d\" => 3]];
echo http_build_query(\$data), PHP_EOL;
echo http_build_query(\$data, \"\", \"&\", PHP_QUERY_RFC3986), PHP_EOL;
"'

# Inspect JIT still uses LLVM today:
rg "__compiler_http_build_query" lib/JIT/Builtin/StringHttpBuildQuery.php

Scope (this repo)

Path	Work
lib/JIT/Builtin/StringHttpBuildQuery.php	Remove hashtable LLVM; call VmHttpBuildQuery via JIT builtin bridge
ext/standard/http_build_query.php	Shared lower() entry for JIT/AOT
ext/standard/VmHttpBuildQuery.php	SSOT (enum/object encoding with #8733)
Tests	test/compliance/cases/stdlib/http_build_query*.phpt JIT section

Done when

• bin/jit.php / AOT http_build_query() delegates to VmHttpBuildQuery — StringHttpBuildQuery LLVM deleted or stub trampoline only
• Repro output matches Zend on same script
• Stdlib: http_build_query() — enum case values must encode like Zend objects not backing scalars (ext/standard/http.c) #8733 enum-case encoding can be fixed once in PHP path
• PR cites lines removed from StringHttpBuildQuery.php

Related

• Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492 · Stdlib: http_build_query() — enum case values must encode like Zend objects not backing scalars (ext/standard/http.c) #8733 enum encoding · php-in-php: JIT StringParseStrJit — route parse_str() through VmHttp PHP not __compiler_parse_str LLVM (#1492) #9295 parse_str JIT cluster

[PurHur]

claim: PHP Runtime → PHP — batch (issues #9293, #9443)

[PurHur]

Unclaiming after #9293 merge: http_build_query JIT migration blocked on native __hashtable__* → PHP array export for VmHttpBuildQuery::build. StringHttpBuildQuery.php (~381 LOC) walks __strkey_node__ inline — needs shared HashTableJitExport helper (or #10031 HashTableHelper PHP migration) before thin-bridge pattern like StringVersionCompare applies. Handoff for next run.

[PurHur]

claim: PHP Runtime → PHP — batch (issues #9480, #9443, #9477)

[PurHur]

Merged via #11098.

Verification:

OK (3 tests) HttpBuildQueryRuntimeShrinkTest
OK (2 tests) VmHttpBuildQueryTest
check-selfhost-spine-coverage-sync: OK

LLVM shrink: ~347 lines removed from StringHttpBuildQuery.php.