Stdlib: preg_grep() — enum case pattern operand must TypeError not silent pass (ext/pcre/php_pcre.c)

[PurHur]

Category

stdlib · php-src-strict

Problem

preg_grep() argument #1 ($pattern) must be string. Passing a backed enum case must throw TypeError with Zend's message. This compiler either coerces silently or prints uncaught without surfacing the expected TypeError.

Distinct from closed #5639 (enum case array values in haystack).

php-src reference

• php/php-src ext/pcre/php_pcre.c — php_pcre_grep argument parsing

Repro

test/repro/maintainer_gap_preg_grep_enum.php (in tree):

<?php
enum E: string { case A = 'x'; }
try {
    preg_grep(E::A, []);
    echo "uncaught\n";
} catch (TypeError $e) {
    echo 'TypeError: ', $e->getMessage(), "\n";
}

php test/repro/maintainer_gap_preg_grep_enum.php
php bin/vm.php test/repro/maintainer_gap_preg_grep_enum.php

	Output
Zend	TypeError: preg_grep(): Argument #1 ($pattern) must be of type string, E given
VM today	uncaught

Scope (this repo)

Path	Work
ext/standard/ or lib/VM/ preg_grep builtin	VmString::coerceStringBuiltinArg / enum guard before pattern use
lib/JIT/Builtin/	Mirror TypeError for enum pattern operand
Tests	extend test/compliance/cases/stdlib/preg_grep_enum_typeerror.phpt

Done when

• VM throws TypeError matching Zend message class + text
• JIT/AOT agree when in scope
• ./script/ci-fast.sh --filter preg_grep_enum green

Related

• Stdlib: preg_grep() must TypeError when array values are enum cases (ext/standard/array.c) #5639 (haystack values — closed)
• Stdlib: preg_split() — enum case subject must TypeError (ext/pcre/php_pcre.c, php-src-strict) #8859 preg_split enum subject
• Stdlib: preg_quote() — enum case operand must TypeError not silent coerce (ext/pcre/php_pcre.c) #8998 preg_quote enum operand
• North star Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: worker-lane-b — batch (issues #8977, #8974, #8998, #9025)

[PurHur]

claim released: worker-lane-b — already green on master (maintainer_gap_preg_grep_enum.php).

[PurHur]

Already fixed on master — shared enum guard correctly throws TypeError. Verified with batch repro on VM.