php-in-php: version_compare() — delete phpc_version_compare.c (~248 lines), JIT/AOT via VmInfo (pairs #5492)

[PurHur]

Category

php-in-php | stdlib | runtime

Problem

version_compare() VM logic already lives in PHP (ext/standard/VmInfo.php, ext/standard/version_compare.php), but JIT/AOT still link a separate ~248-line C translation unit lib/AOT/runtime/phpc_version_compare.c (registered in lib/AOT/Linker.php, called from ext/standard/JitInfo.php via __compiler_version_compare).

Self-host M5 should not maintain duplicate version-string canonicalization in C when VmInfo::version_compare() is the SSOT. Issue #5492 tracks phpc_info.c; this file is a second C runtime copy that must be deleted in the same PHP-in-PHP pass.

php-src reference

• php/php-src ext/standard/versioning.c — PHP_FUNCTION(version_compare) / php_version_compare
• php/php-src ext/standard/info.c — related introspection (see php-in-php: phpc_info.c — delete ~400 lines, phpversion/php_uname/version_compare in ext/standard #5492)

Repro (C runtime still linked)

./script/docker-exec.sh -- bash -lc 'wc -l lib/AOT/runtime/phpc_version_compare.c
rg -n phpc_version_compare lib/AOT/Linker.php ext/standard/JitInfo.php'

Today: 248 lib/AOT/runtime/phpc_version_compare.c + __compiler_version_compare symbol in AOT link set.

Compare with PHP SSOT:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php -r "var_export(version_compare(\"1.0\",\"1.0.0\")); echo PHP_EOL;"'
# int(0)

Enum operand strictness is tracked separately in #5955 (php-src-strict TypeError) — wire the same guards in JIT lowering when deleting C.

Scope (this repo)

Layer	Path
PHP SSOT	ext/standard/VmInfo.php, ext/standard/version_compare.php
JIT	ext/standard/JitInfo.php — lower via PHP helper / shared IR, not __compiler_version_compare
AOT	remove lib/AOT/runtime/phpc_version_compare.c from lib/AOT/Linker.php
C shrink	delete file + symbol; no new logic in runtime/*.c

Done when

• lib/AOT/runtime/phpc_version_compare.c deleted; lib/AOT/Linker.php no longer lists it
• JIT/AOT version_compare() results match VM/VmInfo::version_compare() on compliance fixtures (including operator form)
• Stdlib: version_compare() — enum case operand must TypeError not Error (ext/standard/versioning.c, php-src-strict) #5955 enum-case TypeError repro green on VM and JIT/AOT after C removal
• ./script/ci-fast.sh --filter VersionCompare (or named compliance) green
• PR body notes ~248 lines removed from lib/AOT/runtime/

Links

• Pairs php-in-php: phpc_info.c — delete ~400 lines, phpversion/php_uname/version_compare in ext/standard #5492 (phpc_info.c), Stdlib: version_compare() — enum case operand must TypeError not Error (ext/standard/versioning.c, php-src-strict) #5955 (enum TypeError), closed php-in-php: phpversion/php_uname/extension_loaded — delete phpc_info.c (~400 lines), VM+JIT from ext/standard #6124 (phpc_info migration)

[PurHur]

claim: PHP Runtime → PHP — starting this run (#6277 version_compare: delete phpc_version_compare.c, JIT/AOT from VmInfo + lib/JIT).

[PurHur]

Merged via #6282.

C shrink: deleted lib/AOT/runtime/phpc_version_compare.c (248 lines); JIT/AOT now use StringVersionCompareJit LLVM from VmInfo::phpVersionCompare().

Verification: VersionCompareVMTest (3/3), AOT version_compare.phpt, JIT version_compare("8.2.0","8.1.99") → 1, enum repro TypeError green.