Stdlib: mb_strlen() — enum case operand must TypeError (ext/mbstring/mbstring.c)

[PurHur]

Category

stdlib · php-src-strict

Problem

mb_strlen() rejects enum case operands with LogicException (mb_strlen() only supports strings in this compiler build) instead of Zend’s TypeError (Argument #1 ($string) must be of type string, … given). This is separate from #5524 (ext/standard string.c builtins).

php-src reference

• php/php-src ext/mbstring/mbstring.c — PHP_FUNCTION(mb_strlen) / Z_PARAM_STR
• php/php-src Zend/zend_enum.c — enum cases are objects, not strings

Repro

test/repro/maintainer_mb_strlen_enum.php:

<?php
enum Es: string { case B = 'hi'; }
try {
    echo mb_strlen(Es::B);
} catch (Throwable $e) {
    echo get_class($e).': '.$e->getMessage();
}

docker info >/dev/null
./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_mb_strlen_enum.php'
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_mb_strlen_enum.php'

Engine	Result
Zend	TypeError: mb_strlen(): Argument #1 ($string) must be of type string, Es given
VM	LogicException: mb_strlen() only supports strings in this compiler build

Implementation hints

• ext/mbstring/mb_strlen.php — use VmString::coerceStringBuiltinArg() / EnumCaseSupport::rejectEnumCaseOperand() like ext/standard string builtins (Stdlib: hash()/hash_hmac()/md5()/sha1()/crc32() — enum case operands must TypeError (ext/hash, ext/standard) #5780 pattern).
• Mirror in ext/mbstring/JitMbStrlen.php when touching JIT.

Done when

• VM throws TypeError matching Zend for enum case operand (not LogicException)
• JIT lowerer rejects enum cases with same TypeError when native path exists
• Add test/compliance/cases/stdlib/mb_strlen_enum_typeerror.phpt
• ./script/ci-fast.sh --filter mb_strlen_enum green
• No enum backing-string coercion in runtime/*.c

Related

• Stdlib: string builtins must TypeError on enum case operands (ext/standard/string.c) #5524 · Stdlib: hash()/hash_hmac()/md5()/sha1()/crc32() — enum case operands must TypeError (ext/hash, ext/standard) #5780 hash enum template · Stdlib: mb_strlen() — enum case operand must TypeError (ext/mbstring/mbstring.c) #5873 · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Merged via #7593.

Fix: mb_strlen() VM uses VmString::coerceStringBuiltinArg(); JIT/AOT uses JitStringBuiltinArg::lower() — enum case operands now throw TypeError matching Zend (ext/mbstring/mbstring.c Z_PARAM_STR), not LogicException.

Verification (green):

• `php bin/vm.php test/repro/maintainer_mb_strlen_enum.php` → TypeError
• `vendor/bin/phpunit test/compliance/MbStrlenVMTest.php` → OK (2)
• `vendor/bin/phpunit test/compliance/MbStrlenJITTest.php` → OK (2)
• `php bin/compile.php -l test/repro/maintainer_mb_strlen_enum.php` → exit 0

[PurHur]

Merged residual AOT/JIT enum typename fix in #8457: JitStringBuiltinArg now emits runtime enum class names (Es given) and uncaught AOT errors abort with exit 134. VM/JIT compliance + AOT string_compare_enum_typeerror green. Pre-existing AOT try/catch gap for mb_strlen_enum_typeerror (exit 134 vs expected 0) remains — separate dispatch issue.