php-in-php: JIT readonly pending exception — delete phpc_readonly_raise.c (~77 lines), lib/JIT/ReadonlyBridge.php

[PurHur]

Category

php-in-php

Problem

Readonly property violations in native JIT code use a second C pending buffer (lib/AOT/runtime/phpc_readonly_raise.c, ~77 lines): __compiler_jit_raise_logic_exception() records the message; AOT mains call phpc_jit_abort_if_pending_logic_exception(). This duplicates the Error pending pattern in phpc_error_raise.c and should live in PHP with a thin ABI.

php-src reference

• php/php-src Zend/zend_object_handlers.c — readonly property write guards
• php/php-src Zend/zend_exceptions.c — Error throw on modification

Repro (failure today)

<?php
readonly class R {
    public function __construct(public int $x) {}
}
$r = new R(1);
$r->x = 2;

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/jit.php repro.php 2>&1 | head -5
'

Runtime	Expected
Zend PHP 8.x	Uncaught Error: Cannot modify readonly property R::$x
JIT/AOT today	C buffer in phpc_readonly_raise.c → PHP throw or AOT stderr fatal

Scope (this repo)

Module	Path
Delete C	lib/AOT/runtime/phpc_readonly_raise.c (~77 lines)
PHP bridge	lib/JIT/ReadonlyBridge.php (or shared pending-exception helper with #5371)
JIT	readonly store sites in lib/JIT/Builtin/Type/Object_.php
Tests	test/compliance/cases/language/readonly_jit.phpt (or extend existing readonly suite)

Done when

• phpc_readonly_raise.c deleted from tree and link
• JIT + standalone AOT match Zend Error message for readonly writes
• PR notes ~77 lines removed from lib/AOT/runtime/
• ./script/ci-fast.sh --filter readonly green

Links

• Fix array copy-on-write: keep source after mutating copy (#5340) #5371 (Error pending buffer) · Language: readonly classes (PHP 8.2+) #1360 · Language: readonly properties on non-readonly classes (PHP 8.1+) #3149 · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: PHP Runtime → PHP — starting this run (#5374: verify ReadonlyRaise PHP LLVM path, add ReadonlyBridge facade, close issue).

[PurHur]

Merged via #7272

C runtime shrink: phpc_readonly_raise.c was already deleted (~77 lines); linker unchanged.

PHP path: lib/JIT/ReadonlyBridge.php + ReadonlyRaise::emitRaise() LLVM; ReadonlyClassGuard uses readonly pending buffer; ErrorBridge delegates readonly lifecycle to ReadonlyBridge.

Verification:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
vendor/bin/phpunit test/unit/JIT/ExceptionBridgeTest.php
vendor/bin/phpunit test/compliance/JITTest.php --filter readonly_property_jit
vendor/bin/phpunit test/compliance/VMTest.php --filter readonly_property_write
'

→ 2/2 ExceptionBridge, 2/2 readonly_property_jit, 1/1 readonly_property_write