Language: dynamic property deprecation — JIT/AOT E_DEPRECATED on undeclared write (phase 2 of #3253)

[PurHur]

Category

language

Problem

PHP 8.2+ deprecates creating dynamic properties on classes that do not allow them. #3253 closed VM notices via emitDeprecatedNotice. JIT/AOT property writes on ordinary classes still skip the deprecation path — test/compliance/DynamicPropertyDeprecatedJITTest.php is skipped until MCJIT matches Zend.

Self-host and apps compiled with bin/jit.php / AOT must see the same E_USER_DEPRECATED (respecting error_reporting) as Zend for undeclared writes.

php-src reference

• php/php-src Zend/zend_object_handlers.c — zend_declare_property_error, dynamic property deprecation
• php/php-src Zend/zend_API.c — zend_error(E_DEPRECATED, ...)

Repro (today)

Use test/compliance/cases/language/dynamic_property_deprecation.phpt:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php test/compliance/cases/language/dynamic_property_deprecation.phpt
# JIT (currently skipped in DynamicPropertyDeprecatedJITTest):
php bin/jit.php test/compliance/cases/language/dynamic_property_deprecation.phpt
'

Runtime	Class C undeclared $y
Zend / VM	PHP Deprecated: Creation of dynamic property C::$y then 2
JIT	deprecation missing or test skipped

Scope (this repo)

Module	Path
JIT property set	lib/JIT.php, lib/JIT/Builtin/Type/Object_.php
Deprecation helper	reuse VM message formatting / Compiler\DeprecatedMetadata
Tests	test/compliance/DynamicPropertyDeprecatedJITTest.php — unskip when green

Done when

• dynamic_property_deprecation.phpt passes MCJIT execute (EXPECTF deprecation line + values)
• #[\AllowDynamicProperties] branch still silent (Stdlib: gc_mem_caches() — missing GC cache flush (PHP 8.3, Zend/zend_gc.c) #5109 / Language: #[\AllowDynamicProperties] — permit undeclared writes (Zend zend_attributes.c parity) #3467)
• error_reporting(0) suppresses notice like Zend on JIT path

[PurHur]

Cross-ref fix: #[\\AllowDynamicProperties] JIT tracker is #5110, not #5109 (#5109 is gc_mem_caches()).

[PurHur]

claim: cursor-agent-lane-c — starting this run

[PurHur]

Progress (lane C) — partial, MCJIT execute blocker

Claim: cursor-agent-lane-c

Landed in branch agent/issue-5111-dynamic-property-deprecation-jit

• IR lowering: Block::collectJitUndeclaredInstancePropertyWrites() + Object_::definePendingUndeclaredInstanceProperties() after compileClass so new C() allocates slots for compile-time-discovered dynamic writes (fixes slot skew that caused MCJIT miscompilation).
• Native slots: user-class dynamic properties predefine as TYPE_NATIVE_LONG (VALUE-box propertyStore IR segfaults during lowering for undeclared writes).
• Test: DynamicPropertyDeprecationJitCompileTest — jitCompileBlock() succeeds for undeclared write repro.

Still open (issue Done when)

• Block::requiresVmLowering still includes containsDynamicPropertyDeprecationOpcodes — bin/jit.php VM-fallbacks whole script; compliance PHPT passes via VM, not MCJIT execute.
• MCJIT run() segfaults on this host when requiresVmLowering is cleared (bin/jit.php test/repro/dyn-min.php → exit 139; even class C { public int $x = 1; } $c = new C(); without dynamic write). script/jit-runtime-probe.php also fails (exit 1). Needs execute debugging before unskipping VM gate.

Verification (green on branch)

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php vendor/bin/phpunit test/unit/DynamicPropertyJitPredefineTest.php
php vendor/bin/phpunit test/unit/DynamicPropertyDeprecationJitCompileTest.php
php vendor/bin/phpunit test/compliance/DynamicPropertyDeprecatedJITTest.php
'

Next: drop containsDynamicPropertyDeprecationOpcodes from requiresVmLowering once bin/jit.php test/compliance/cases/language/dynamic_property_deprecation.phpt runs MCJIT without segfault; re-add DynamicPropertyDeprecationJitExecuteTest for execute + error_reporting(0).

[PurHur]

claim: cursor-agent-lane-c — continuing WIP PR #5183 this run (MCJIT execute + unskip compliance test)

[PurHur]

Handoff: MCJIT execute still blocked here — script/jit-runtime-probe.php exits 1 on origin/master too (container MCJIT). Branch #5183 keeps requiresVmLowering until probe green; compile tests pass. Continuing #5168 this run.

[PurHur]

worker-lane-c: rebased agent/issue-5111-dynamic-property-deprecation-jit onto master (probe OK). MCJIT compile green; execute still segfaults on dynamic-property scripts when requiresVmLowering is cleared — PR #5183 not merged this run.

[PurHur]

claim: cursor-agent-lane-c — continued PR #5183 this run; merge blocked on MCJIT execute

Verification (green)

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php vendor/bin/phpunit test/unit/DynamicPropertyJitPredefineTest.php
php vendor/bin/phpunit test/unit/DynamicPropertyDeprecationJitCompileTest.php
php vendor/bin/phpunit test/unit/DynamicPropertyDeprecationLoweringTest.php
php vendor/bin/phpunit test/compliance/DynamicPropertyDeprecatedJITTest.php
php script/jit-runtime-probe.php
'

• JIT compile (undeclared write IR + definePendingUndeclaredInstanceProperties native-long slots): OK
• Compliance PHPT via bin/jit.php + requiresVmLowering VM fallback: OK
• jit-runtime-probe (echo 2+2 subprocess): OK

Blocker (issue Done when — MCJIT execute)

Clearing containsDynamicPropertyDeprecationOpcodes from Block::requiresVmLowering and running MCJIT execute still segfaults (exit 139) on this host’s php-compiler:22.04-dev image — including scripts without dynamic-property deprecation:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
echo "<?php class C{public int \$x=1;} \$c=new C(); echo \$c->x;" | php bin/jit.php -
# exit 139 — same on origin/master without this branch
'

Runtime::jit() + run() in-process also segfaults for user-class scripts; only trivial echo 2+2 probe passes.

Next step: fix MCJIT execute for user-defined classes (container/runtime), then drop VM gate and unskip execute assertion on dynamic_property_deprecation.phpt.

PR: #5183

[PurHur]

claim: cursor-agent-lane-c — continued PR #5183 this run

Verification (green on branch)

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php script/jit-runtime-probe.php
php vendor/bin/phpunit test/unit/DynamicPropertyJitPredefineTest.php
php vendor/bin/phpunit test/unit/DynamicPropertyDeprecationJitCompileTest.php
php vendor/bin/phpunit test/unit/DynamicPropertyDeprecationLoweringTest.php
php vendor/bin/phpunit test/compliance/DynamicPropertyDeprecatedJITTest.php
php vendor/bin/phpunit test/compliance/DynamicPropertyDeprecationVMTest.php
'

Blocker (issue Done when — true MCJIT execute)

DynamicPropertyDeprecatedJITTest passes via bin/jit.php VM fallback (Block::requiresVmLowering → skip Runtime::jit()). That matches Zend output but is not MCJIT execute.

Bisect (test/repro-maintainer/jit_class_property_mcjit.php on branch):

Case	bin/jit.php subprocess	Path
echo new C() (no property)	exit 0	MCJIT
$c->x (declared property)	exit 139	MCJIT segfault
$c->y = 2 (undeclared write)	exit 0 + deprecation	VM fallback (requiresVmLowering)

Root cause for #5111: MCJIT execute segfaults on any user-class instance property fetch/store (untyped_prop / typed_prop), not just dynamic writes. JIT compile + definePendingUndeclaredInstanceProperties are green; execute needs MCJIT property access fixed first.

Next step: fix MCJIT instance property fetch/store for user classes (broader than #5111), then drop containsDynamicPropertyDeprecationOpcodes from requiresVmLowering and add DynamicPropertyDeprecationJitExecuteTest.

PR #5183 remains open — not merging until MCJIT execute repro is green without VM gate.

[PurHur]

claim: cursor-agent-lane-c — continuing PR #5183 this run