Stdlib: ReflectionProperty::getAsymmetricVisibility() — set/get masks (ext/reflection/php_reflection.c) #5060

Activity

1. PurHur

   added

   enhancementNew feature or requestNew feature or request

   phase-4:stdlibPhase 4 – stdlib for web appsPhase 4 – stdlib for web apps

   area:vmVirtual machineVirtual machine

   implementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimSpec complete: repro, php-src ref, done-when — safe for workers to claim

   on Jun 3, 2026
2. PurHur commented on Jun 6, 2026

   

   PurHur

   on Jun 6, 2026

   OwnerAuthor

   More actions

   Spec expansion (parity backlog run, Jun 2026)

   This issue is blocked on language surface until asymmetric visibility compiles — see #6861 (public private(set) parse fails today). Without #6861, repro sources using asymmetric properties never reach reflection.

   Dependency chain (claim order)

   1. Language: asymmetric visibility syntax (PHP 8.4 public private(set)) — parse fails Multiple access type modifiers #6861 — asymmetric visibility syntax + VM get/set enforcement
   2. Stdlib: ReflectionProperty::getAsymmetricVisibility() — set/get masks (ext/reflection/php_reflection.c) #5060 (this issue) — ReflectionProperty::getAsymmetricVisibility()
   3. Stdlib: ReflectionProperty::getAsymmetricVisibility() — static properties return wrong/null (ext/reflection/php_reflection.c) #6772 — static asymmetric properties return wrong/null (extends this API)
   4. Stdlib: get_class_vars() — static asymmetric properties missing from returned map (ext/standard/class.c) #6771 — get_class_vars() must expose static asymmetric entries

   Repro (still failing today)

   <?php
   class C {
       public private(set) string $name = 'x';
   }
   $r = new ReflectionProperty(C::class, 'name');
   var_export($r->getAsymmetricVisibility());
   echo "\n";

   # PHP 8.4+ reference
   php repro.php
   # array('set' => ReflectionProperty::IS_PRIVATE, 'get' => ReflectionProperty::IS_PUBLIC) — bitmask ints
   
   ./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
   php bin/vm.php repro.php 2>&1 | head -3
   '
   # today: fails at compile (#6861) or undefined method

   Symmetric control:

   class S { public string $name = 'x'; }
   var_export((new ReflectionProperty(S::class, 'name'))->getAsymmetricVisibility());
   // Zend: NULL

   php-src reference

   • ext/reflection/php_reflection.c — reflection_property_get_asymmetric_visibility
   • Zend/zend_compile.c — asymmetric ACC flags stored on property metadata

   Done when (unchanged + explicit)

   • Language: asymmetric visibility syntax (PHP 8.4 public private(set)) — parse fails Multiple access type modifiers #6861 green first (or same PR if worker owns chain)
   • getAsymmetricVisibility() returns null for symmetric properties
   • private(set) returns Zend-equivalent set/get integer bitmasks (IS_PRIVATE, IS_PUBLIC, …)
   • ./script/ci-fast.sh --filter reflection_property_asymmetric_visibility green

   PHP-in-PHP: reflection metadata from compiler flags in lib/ / VmReflection.php; no C reflection tables.
3. PurHur commented on Jun 12, 2026

   

   PurHur

   on Jun 12, 2026

   OwnerAuthor

   More actions

   claim: PHP Compiler STD Lib — starting this run
4. PurHur

   added a commit that references this issue on Jun 12, 2026

   Implement ReflectionProperty::getAsymmetricVisibility() for instance …

   ...

   c327eeb
5. PurHur

   closed this as completedin #8199on Jun 12, 2026
6. PurHur commented on Jun 12, 2026

   

   PurHur

   on Jun 12, 2026

   OwnerAuthor

   More actions

   Merged via #8199.

   Verification

   ./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
   php bin/vm.php test/repro-maintainer/reflection_get_asymmetric_visibility_5060.php
   vendor/bin/phpunit --filter reflection_property_asymmetric_visibility
   php bin/compile.php -l test/repro-maintainer/reflection_get_asymmetric_visibility_5060.php
   '

   → asymmetric instance/static return ['get'=>256,'set'=>1024] / ['get'=>256,'set'=>512]; symmetric null; PHPUnit OK; AOT lint exit 0.

   PHP path: lib/VM/Builtin/ReflectionPropertyGetAsymmetricVisibility.php + VmReflection::propertyVisibilityMeta() / visibilityToReflectionBitmask(). No C runtime changes.
7. PurHur

   added

   stdlib

   IMPORTANTCritical pathCritical path

   on Jun 19, 2026