Stdlib: array_rand() — numeric-string $num must coerce to int (ext/standard/array.c parity)

[PurHur]

Category

stdlib · runtime

Summary

array_rand() argument #2 ($num) must accept numeric strings (e.g. "1") with Zend int coercion. VM/JIT require native TYPE_INTEGER and throw LogicException.

Problem

Second parameter $num is not coerced from numeric strings before validation, so valid Zend calls fail at runtime.

php-src reference

• php/php-src ext/standard/array.c — PHP_FUNCTION(array_rand) (zend_parse_parameters long / numeric string)

Repro

HARNESS_DOCKER_RUN_OPTS='--memory=8g --cpus=2' ./script/docker-exec.sh -- bash -lc '
  source script/php-env.sh
  php -r "var_dump(array_rand([\"a\",\"b\"], \"1\"));"
  php bin/vm.php -r "var_dump(array_rand([\"a\",\"b\"], \"1\"));"
'

Mode	array_rand(['a','b'], '1')
Zend	int(0) or int(1) (valid key)
VM	LogicException — argument #2 must be an integer

Scope (this repo)

Area	Files
VM	ext/standard/array_rand.php, ext/standard/VmArray.php (arrayRandPacked())
JIT	ext/standard/JitArrayRand.php
Tests	test/compliance/cases/stdlib/array_rand_num_numeric_string.phpt

Done when

• Repro passes on VM and JIT/AOT with int key in range
• Non-numeric strings still throw Zend TypeError / ValueError per php-src
• Patterns aligned with array_chunk / array_slice numeric-string issues

Implementation notes

• Use shared int coercion helper (see closed numeric-string issues in ext/standard/).
• Reuse test/repro-maintainer/array_rand_validation.php where applicable.

Links

• Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: PHP Runtime → PHP — starting this run (#4320: array_rand() numeric-string $num coercion).

[PurHur]

Merged via #8382.

Change: VM array_rand() uses VmMath::parseIntBuiltinArg() for $num — numeric strings like "1" coerce to int; non-numeric strings get Zend-shaped TypeError. JIT already routed through JitLongArg; added VM+JIT compliance .phpt files.

Verification:

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php -r "var_dump(array_rand([\"a\",\"b\"], \"1\"));"
php bin/vm.php -r "var_dump(array_rand([\"a\",\"b\"], \"1\"));"
php bin/jit.php -r "var_dump(array_rand([\"a\",\"b\"], \"1\"));"
vendor/bin/phpunit --filter ArrayRand
'

→ Zend/VM/JIT all return valid int keys; PHPUnit OK (5 tests, 25 assertions).

No C runtime changes.