Stdlib: str_repeat() — multiplier must accept numeric strings and floats (ext/standard/string.c parity)

[PurHur]

Category

stdlib

Problem

Zend coerces str_repeat() argument #2 ($times) from float or numeric string to int. Negative values throw ValueError. This compiler requires a native integer type and throws LogicException before Zend-compatible coercion runs.

php-src reference

• php/php-src ext/standard/string.c — PHP_FUNCTION(str_repeat) validates/coerces $times via _zend_parse_arg_long()

Repro

<?php
echo str_repeat('x', 2.9) . "\n"; // Zend: xx
try {
    str_repeat('x', -1);
} catch (ValueError $e) {
    echo get_class($e) . ': ' . $e->getMessage() . "\n";
}

./script/docker-exec.sh -- bash -lc '
  source script/php-env.sh
  php test/repro-maintainer/str_repeat_numeric_multiplier.php
  php bin/vm.php test/repro-maintainer/str_repeat_numeric_multiplier.php
'

Mode	2.9	-1
Zend	xx	ValueError
VM today	LogicException	ValueError (OK) but float path blocked

Scope

Area	Files
VM	ext/standard/str_repeat.php, ext/standard/VmString.php
JIT/AOT	ext/standard/str_repeat.php, ext/standard/JitStrRepeat.php
Tests	test/compliance/cases/stdlib/str_repeat_numeric_multiplier.phpt

Done when

• Float/numeric-string $times coerces to int on VM, JIT, and AOT
• Negative $times still throws ValueError with Zend message family
• Existing str_repeat PHPTs still pass

[PurHur]

claim: worker-lane-b — starting this run

[PurHur]

Merged via #8305

Fix: VM uses VmMath::parseIntBuiltinArg(); JIT uses JitIntdiv::lowerIntBuiltinArg() for $times (php-src Z_PARAM_LONG / ext/standard/string.c).

Verification:
```bash
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php test/repro-maintainer/str_repeat_numeric_multiplier.php
php bin/vm.php test/repro-maintainer/str_repeat_numeric_multiplier.php
php vendor/bin/phpunit --filter str_repeat test/compliance/VMTest.php test/compliance/JITTest.php
'
```
Repro: str_repeat('x', 2.9) → xx, str_repeat('y', '3') → yyy, negative still ValueError. PHPUnit str_repeat filter: OK (4 tests).