Stdlib: array_keys() / array_values() — TypeError when argument is not array (ext/standard/array.c parity)

[PurHur]

Category

stdlib | runtime

Problem

Same class of Zend mismatch as #4135 (array_key_exists / in_array / array_search): non-array input must raise TypeError, not LogicException.

array_keys() and array_values() currently use build-specific LogicException messages when the array argument is not an array (including objects).

php-src reference

• php/php-src ext/standard/array.c — PHP_FUNCTION(array_keys), PHP_FUNCTION(array_values)

Repro

<?php
$o = new stdClass();
foreach (['array_keys', 'array_values'] as $fn) {
    try {
        $fn($o);
    } catch (TypeError $e) {
        echo "$fn: TypeError\n";
    } catch (Throwable $e) {
        echo "$fn: ", get_class($e), "\n";
    }
}

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php repro.php'

Runtime	array_keys($o)
Zend PHP 8.x	TypeError: array_keys(): Argument #1 ($array) must be of type array, stdClass given
This compiler	LogicException: ... must be an array in this compiler build

Scope

Files
ext/standard/array_keys.php, array_values.php
JIT helpers if array builtins inline type checks
PHPT under test/compliance/cases/stdlib/

Done when

• Repro reports TypeError for both functions on VM
• Coordinate message format with Stdlib: array_key_exists() / in_array() / array_search() — TypeError when array argument is not array (ext/standard/array.c parity) #4135 (shared helper for array-arg TypeError)
• ./script/ci-fast.sh --filter array_keys_type green

Links

• Stdlib: array_key_exists() / in_array() / array_search() — TypeError when array argument is not array (ext/standard/array.c parity) #4135 (sibling builtins) · Language: throw expressions and Exception object propagation #195 (Error types)

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Merged via #4142.

Fix: VmArray::requireArray() runs before the returnVar === null early return (statement calls were skipping the check). JIT uses JitArrayElem::requireArrayArg() shared with array_first/array_last.

Verification: vendor/bin/phpunit --filter 'array_keys_type|ArrayKeysValuesTypeError' — OK (4 tests). AOT: php bin/compile.php -l on repro with array_keys(new stdClass()) — exit 0.