Language: PHP 8.4 asymmetric visibility private(set) — JIT enforce + catchable Error (phase 2 of #3165)

[PurHur]

Category

language

Problem

public private(set) T $prop is enforced on VM (#3165) but JIT either skips the guard or surfaces a non-catchable LogicException instead of Zend’s Error, so scripts using try/catch (Error) diverge.

Capability: docs/capabilities-syntax.md — asymmetric visibility JIT: no.

php-src reference

• Zend/zend_compile.c — ZEND_ACC_PRIVATE_SET
• Zend/zend_object_handlers.c — zend_check_property_access

Repro

<?php
class User {
    public private(set) string $name = 'a';
}
$u = new User();
try {
    $u->name = 'b';
    echo "no error\n";
} catch (Error $e) {
    echo $e->getMessage(), "\n";
}

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh \
  && php bin/vm.php test/repro-maintainer/asymmetric_set.php \
  && php bin/jit.php test/repro-maintainer/asymmetric_set.php'

Mode	Behavior
Zend	catchable Error: Cannot modify private(set) property User::$name from global scope
VM	message printed (fatal path)
JIT	uncaught LogicException (not catchable as Error)

Maintainer repro: test/repro-maintainer/asymmetric_set.php
Compliance exists: test/compliance/cases/language/asymmetric_visibility.phpt (VM-only gate in JITTest.php).

Scope

• lib/JIT/ property write guards (mirror VM asymmetric set visibility)
• Throw Error (not LogicException) to match Zend
• Enable JIT compliance row for asymmetric_visibility*.phpt

Done when

• JIT repro prints the same message via catch (Error)
• JITTest no longer skips asymmetric_visibility JIT cases
• ./script/ci-fast.sh --filter asymmetric_visibility green

Links

• Language: PHP 8.4 asymmetric property visibility (public/private(set), etc.) #3165 · Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: cursor-agent-lane-b — starting this run

[PurHur]

Merged via #4089

Verification

• php bin/vm.php / php bin/jit.php on test/repro-maintainer/asymmetric_set.php → catchable Error message
• vendor/bin/phpunit --filter asymmetric_visibility → OK (3 tests) including new asymmetric_visibility_jit_try.phpt
• Uncaught asymmetric_visibility.phpt remains JIT-skipped (MCJIT segfault on property fetch; CI: Run JIT compliance tests in CI (fix LLVM skip in PHPUnit) #98)