Repository navigation
Language: property hooks JIT — MCJIT execute with builtin calls in hook body (phase 2 of #3145) #4025
Description
Category
language
Problem
PHP 8.4 property hooks VM + JIT dispatch landed (#3145, #3723), but capability-syntax-lib.php notes MCJIT execute still segfaults when a set-hook body calls ordinary builtins such as str_contains(). That blocks self-host / compliance paths that compile hook bodies natively.
php-src reference
- php/php-src
Zend/zend_compile.c— property hook lowering - php/php-src
Zend/zend_object_handlers.c— hook invocation on read/write
Repro
<?php
class U {
public string $e {
set (string $v) {
$this->e = str_contains($v, '@') ? $v : $v . '@local';
}
}
}
$o = new U();
$o->e = 'user';
echo $o->e, "\n";./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php bin/vm.php repro.php # VM: user@local (or Zend-equivalent)
php bin/jit.php repro.php 2>&1 | tail -5 # JIT: segfault / abort today
'Scope
| Layer | Files |
|---|---|
| JIT | lib/JIT/PropertyHookDispatch.php, lib/JIT.php — ensure hook invoke preserves frame, $this, raw-property write slot |
| Builtin calls inside hook | verify TYPE_FUNCCALL from hook method IR does not corrupt MCJIT stack |
| Tests | extend test/compliance/cases/language/property_hook_set.phpt with str_contains body |
Done when
-
bin/jit.phprepro prints same line as VM without segfault -
./script/ci-fast.sh --filter property_hookgreen - Remove segfault note from
capability-syntax-lib.phpproperty_hooks row
Activity
PurHur commentedon Jun 1, 2026
claim: cursor-lane-c-worker — starting this run
Language: JIT property hook raw backing writes (#4025) (#4059)
PurHur commentedon Jun 1, 2026
Merged via #4059.
Fix: While lowering
__phpc_property_set_*methods, JIT now setsContext::jitPropertyHookRawPropertyso assignments to the backing property inside the hook body callpropertyStoredirectly instead of re-enteringPropertyHookDispatch(infinite hook recursion → MCJIT segfault).Verification (harness):
```bash
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter PropertyHook'
```
→ OK (6 tests;
PropertyHookJitExecuteTestskipped untilscript/jit-runtime-probe.phpis green).When MCJIT probe passes,
bin/jit.php test/repro-maintainer/property_hook_jit.phpshould match VM (reject/a@b.c).php-src:
Zend/zend_property_hooks.c