Stdlib: number_format() — numeric string coercion (ext/standard/number_format.c parity)

[PurHur]

Summary

number_format() rejects numeric strings for argument #1 ("1234.5"), while Zend coerces numeric strings to float/int before formatting. This breaks common web/form code paths.

Related but distinct from #3549 (internal strpos/strlen rules).

php-src reference

• ext/standard/number_format.c — PHP_FUNCTION(number_format) uses ZEND_PARSE_PARAMETERS with numeric coercion

Repro

<?php
echo number_format("1234.567", 2), "\n"; // Zend: 1,234.57

This compiler (VM):

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php -r "echo number_format(\"1234.5\", 2), \"\\n\";"'
# LogicException: number_format() number must be an integer or float in this compiler build

Current guard: ext/standard/number_format.php lines 37–38 (strict int/float only).

Expected

• Accept int, float, and numeric strings (including "1234.5", "1e3").
• Reject non-numeric strings with TypeError (PHP 8+) or Warning+0 per Zend for invalid input.
• JIT/AOT: same coercion in JitNumberFormat::format().

Scope

• VM + JIT + AOT.
• Compliance: test/compliance/cases/stdlib/number_format_numeric_string.phpt.

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Merged via PR #3894 (Lane C worker verification run).

Verification (Docker harness):

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro-maintainer/number_format_numeric_string.php'
# 1,234.57
# 1,000

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/compliance/VMTest.php --filter number_format_numeric_string'
# OK (1 test, 1 assertion)

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/aot/AotTest.php --filter number_format'
# OK (1 test, 5 assertions)

number_format() now coerces numeric strings per php-src ext/standard/number_format.c.