AOT: mb_trim()/mb_ltrim()/mb_rtrim() refuse runtime encoding — LogicException (leftover of #34379, ext/mbstring/mbstring.c)

[PurHur]

Category

bug · AOT mbstring leftover · compile abort

Problem

#34379 NestedJIT'd runtime haystacks for mb_trim/mb_ltrim/mb_rtrim, but JitMbTrim::runtimeEncodingLiteral still requires a compile-time encoding string and throws LogicException when $encoding is runtime. Thin AOT cannot compile mb_trim($s, null, enc('UTF-8')).

Repro (PROFILE=8.4)	VM	AOT (master)
mb_trim(" a ", null, enc('UTF-8'))	a	compile LogicException: encoding must be a string literal
mb_trim(" a ", null, enc('nope'))	Zend ValueError	same compile abort

php-src reference

• php/php-src ext/mbstring/mbstring.c — PHP_FUNCTION(mb_trim)

PHP implementation target

• ext/mbstring/JitMbTrim.php — runtime encoding via NestedJIT assert + ptr (peer JitMbScrub / AOT: mb_scrub() refuses runtime encoding — LogicException (leftover of #34338, ext/mbstring/mbstring.c) #35161 / AOT: mb_convert_kana() refuses runtime encoding — LogicException (leftover of #34294, ext/mbstring/mbstring.c) #35193)
• ext/mbstring/MbTrimJitHelper.php — assertEncodingArgv (Argument Stdlib: ceil, floor, intval and expanded PHPT specs #3)
• lib/JIT/Builtin/MbTrimRuntime.php — link assert helper
• No new runtime/*.c

Repro

./script/docker-exec.sh -- bash -lc 'export PHP_COMPILER_PROFILE=8.4
php bin/vm.php test/repro/aot_mb_trim_runtime_encoding.php
php bin/compile.php -o /tmp/mbtrim.bin test/repro/aot_mb_trim_runtime_encoding.php && /tmp/mbtrim.bin'

Done when

• AOT binary matches VM on runtime 8BIT/ASCII/UTF-8 encodings
• Invalid runtime encoding raises Zend ValueError under AOT (and VM)
• ./script/aot-smoke.sh stays 8/8
• No new hand-written C runtime

Parent

• Prior NestedJIT strings: AOT: mb_trim/mb_ltrim/mb_rtrim refuse runtime strings — LogicException (leftover of #5957/#23883, ext/mbstring/mbstring.c) #34379 / AOT: fix mb_trim NestedJIT ABI (SIGSEGV/empty) leftover of #34388 #34396
• Peer runtime-encoding: AOT: mb_scrub() refuses runtime encoding — LogicException (leftover of #34338, ext/mbstring/mbstring.c) #35161 / AOT: mb_convert_kana() refuses runtime encoding — LogicException (leftover of #34294, ext/mbstring/mbstring.c) #35193 / AOT: mb_strtolower()/mb_strtoupper()/mb_ucfirst()/mb_lcfirst() refuse runtime encoding — LogicException (leftover of #34625, ext/mbstring/mbstring.c) #34858

[PurHur]

claim: php-runtime-migration — mb_trim/ltrim/rtrim runtime encoding via NestedJIT assertEncodingArgv (peer #35161 / #35193)

[PurHur]

claim: implementing AOT runtime encoding for mb_trim/mb_ltrim/mb_rtrim (peer #35193/#35187; no open DOM IR).

[PurHur]

claim: worker-lane-B — starting this run (lane overflow: AOT compile LogicException; prior claims have no PR/branch after ~5m; peer #35193/#35187 runtime encoding)

[PurHur]

Progress note (worker-lane-B) — blocked on NestedJIT trim regression

Attempted runtime-encoding assert (peer #35193 / MbScrubJitHelper::assertEncodingArgv). Stopped: NestedJIT mb_trim/mb_rtrim is already wrong on current master for runtime haystacks, so wiring encoding cannot meet Done-when.

Evidence (master @ d698174, PHP_COMPILER_PROFILE=8.4, PHP_COMPILER_HELPER_RUNTIME_O=0)

• vendor/bin/phpunit --filter MbTrimRuntimeAotTest → FAIL testAotRuntimeMatchMatchesVm
  • expected hi / hi / x; AOT gives h / empty-ish / x�
• test/repro/aot_mb_trim_runtime.php VM vs AOT DIFF (same shape)
• Minimal: mb_rtrim(s(" a "), null, "UTF-8") → VM [ a], AOT []

Next step

1. Re-fix NestedJIT MbTrimJitHelper rtrim/trim bodies (leftover of AOT: fix mb_trim NestedJIT rtrim wrong output (leftover #34396) #34532 / AOT: fix mb_trim NestedJIT ABI (SIGSEGV/empty) leftover of #34388 #34396) until MbTrimRuntimeAotTest is green.
2. Then add runtime encoding via NestedJIT assertEncodingArgv (Argument Stdlib: ceil, floor, intval and expanded PHPT specs #3) — prefer a separate helper unit from the C2-hold rtrim body so throw IR does not share that module.
3. Repro: test/repro/aot_mb_trim_runtime_encoding.php (not committed this run).

Not merging incomplete encoding work while NestedJIT trim is red.