php-in-php: drop Context ensureMinimalUserStandaloneBodies always-on StringTriggerError — lazy at call sites

[PurHur]

Category

Foundation · php-in-php · runtime-shrink · cold-build / #32122 class

Problem

Context::ensureMinimalUserStandaloneBodies() still eagerly NestedJIT/links StringTriggerError on every thin AOT user-script init (hello-world / aot-smoke path), even when the script never calls trigger_error / undefined-array-key / related warning ABIs:

• StringTriggerError::ensureStandaloneBodies → StringTriggerErrorJit::implement (NestedJIT / bridge)

Same always-on NestedJIT vs Runtime ABI drift / cold-build surface class as closed #34631 / #34621 / #34612 / #34605. Leftover Context NestedJIT vs Runtime ABI drift mints *.1 (#31894 / #32122).

Call sites already StringTriggerError::ensureLinked before lookup (ext/standard/trigger_error_.php, JitBuiltinWarning, JitIncDec, HashTableResourceKeyLlvm, …). Peer #33234 dropped Type always-on shells for the same reason.

php-src reference

• php/php-src Zend/zend_error.c — php_error_docref / trigger_error path
• Peer: #33234 Type always-on drop; #34631 LastError lazy from ensureMinimal

PHP implementation target

• lib/JIT/Context.php ensureMinimalUserStandaloneBodies — remove StringTriggerError::ensureStandaloneBodies
• Keep full standalone ensureFullStandaloneBodies linking (after AssertFail peers)
• Update ContextMinimalStandaloneLazyLastErrorRuntimeShrinkTest keep-list
• Unit shrink test + ./script/aot-smoke.sh 8/8

Done when

• ensureMinimalUserStandaloneBodies does not call StringTriggerError::ensureStandaloneBodies
• Call-site ensureLinked coverage remains for trigger_error / undef-key paths
• ./script/aot-smoke.sh stays 8/8
• Targeted unit shrink test green

[PurHur]

claim: implementer-worker-lane-a — starting this run (lane A: 34641%3==0; overflow from empty AOT IR queue after #32122/#31968/#34635; Trust-class ensureMinimal NestedJIT shrink peer #34631).

[PurHur]

merged in #34643

verification:

• ./script/phpunit.sh --filter 'ContextMinimalStandaloneLazyStringTriggerErrorShrinkTest|ContextMinimalStandaloneLazyLastErrorRuntimeShrinkTest' → OK (8 tests, 49 assertions)
• ./script/aot-smoke.sh → 8/8
• AOT test/repro/issue_34641_trigger_error_aot.php matches Zend (hi)