php-in-php: drop Context ensureMinimalUserStandaloneBodies always-on LastErrorRuntime — lazy at error_get_last/trigger_error (peer #34621)

[PurHur]

Category

Foundation · php-in-php · runtime-shrink · cold-build / #32122 class

Problem

Context::ensureMinimalUserStandaloneBodies() still eagerly NestedJIT/links LastErrorRuntime on every thin AOT user-script init (hello-world / aot-smoke path), even when the script never calls error_get_last / error_clear_last:

• LastErrorRuntime::ensureStandaloneBodies → NestedJIT ErrorLastJitHelper + __phpc_last_error_* bridges (ends with clearInsertionPosition())

Same always-on NestedJIT vs Runtime ABI drift / cold-build surface class as closed #34621 / #34612 / #34605 / #32122 .1-mint risk.

Call sites already ensure before use:

• ext/standard/JitErrorGetLast.php — invoke / clear → LastErrorRuntime::ensureLinked
• ext/standard/JitTriggerErrorKernel.php — implement → LastErrorRuntime::ensureLinked (also covers thin init when StringTriggerError stays always-on)

LastErrorRuntime::implement must capture/restore builder insert (peer JitHelperAbiBridge / #34621) so mid-{main} ensureLinked is safe — today it always clearInsertionPosition().

php-src reference

• php/php-src ext/standard/basic_functions.c — error_get_last / error_clear_last

PHP implementation target

• lib/JIT/Builtin/LastErrorRuntime.php — capture/restore insert around implement (do not always clear)
• lib/JIT/Context.php — remove LastErrorRuntime::ensureStandaloneBodies from ensureMinimalUserStandaloneBodies(); keep htmlspecialchars / echo / trigger_error / argv / env essentials
• Full standalone still ensureStandaloneBodies in ensureFullStandaloneBodies

Repro

./script/docker-exec.sh -- bash -lc 'script/cold-build-check.sh'
./script/aot-smoke.sh

Done when

• ensureMinimalUserStandaloneBodies does not call LastErrorRuntime::ensureStandaloneBodies
• LastErrorRuntime::implement restores builder insert (peer php-in-php: drop Context ensureMinimalUserStandaloneBodies always-on JitReturnPending — lazy at try/finally (peer #34612) #34621)
• ./script/aot-smoke.sh stays 8/8
• script/cold-build-check.sh ok
• AOT error_get_last / trigger_error still match Zend
• No new runtime/*.c

Parent

• Peer: #34621
• Cold-build class: #32122

[PurHur]

claim: php-runtime-migration — implementing LastErrorRuntime lazy from ensureMinimal (#34631 / peer #34621). #32122/#31968 children closed; C floor empty; continuing ensureMinimal shrink.