php-in-php: drop Type::initialize always-on SessionStorageGlobals::ensureGlobals — lazy at session call sites (peer #34550)

[PurHur]

Category

Foundation · php-in-php · runtime-shrink · cold-build / #32122 class

Problem

Type::initialize still eagerly SessionStorageGlobals::ensureGlobals on every full-load path after the CallArgv batch (#34550).

Always-on LLVM module globals (__phpc_session_id_storage, __phpc_session_name_storage, __phpc_session_active, …) on every full load for scripts that never touch session_* is leftover Type::initialize debt after the #32122 .1-mint shrink wave.

Call sites already ensure before use:

• ext/standard/JitSessionStorageKernel.php / JitSessionLifecycleKernel.php / JitSessionStatus.php / JitSessionCacheExpire.php
• lib/JIT/Builtin/SessionId.php / SessionName.php / SessionModuleName.php
• SessionGcRuntime / SessionEncodeRuntime / SessionCreateIdRuntime
• SessionStorageGlobals::emitCallEnsureDefaults / implementEnsureDefaults

php-src reference

• php/php-src ext/session/session.c — PS(id), PS(session_name), session module state

PHP implementation target

• lib/JIT/Builtin/Type.php — remove SessionStorageGlobals::ensureGlobals from initialize()
• Add TypeDeadTypeInitializeLazySessionStorageGlobalsRuntimeShrinkTest (peer php-in-php: drop Type::initialize always-on CallArgv::implement — lazy ensureGlobal at emitStore/load (peer #34534) #34550)
• Update prior TypeDead* tests that asserted ensureGlobals stays
• No new runtime/*.c / lib/AOT/runtime/*.c

Repro

./script/aot-smoke.sh
./script/docker-exec.sh -- bash -lc 'script/cold-build-check.sh'
./script/phpunit.sh --filter 'TypeDeadTypeInitializeLazySessionStorageGlobals|SessionStorageGlobalsStandalone|SessionStorageRuntimeShrink'
./script/docker-exec.sh -- bash -lc 'printf "%s\n" "<?php session_start(); echo session_id() !== \"\" ? \"ok\" : \"fail\", PHP_EOL;" >/tmp/ss.php && php bin/compile.php -o /tmp/ss.bin /tmp/ss.php && /tmp/ss.bin'

Done when

• Type::initialize does not call SessionStorageGlobals::ensureGlobals
• session_start / session_id still work under AOT (lazy ensureGlobals)
• cold-build-check + aot-smoke 8/8 stay green
• No new runtime/*.c

Parent

• Peer: #34550
• Trust class: #32122 / #31894

[PurHur]

claim: php-runtime-migration — starting this run (Type::initialize leftover after #34550; #32122/#31968 closed; #34564 claimed by lane-B)