Repository navigation
Regression: AOT RecursiveTreeIterator foreach — Module.php:180 cross-function BBs (re-#27584, ext/spl/spl_iterators.c) #33974
Description
Category
bug · php-src-strict · AOT · SPL · pillar 4 (Correctness)
Problem
On master @ 2b3c52fd64, thin AOT compile of RecursiveTreeIterator foreach fails module verification (Module.php:180) with cross-function basic blocks (rti_walk_adv, ht_values_pk_head_*). Zend / VM match the expected tree strings.
ParentIterator / MultipleIterator alone still match Zend under AOT; the walk ABI is the regression surface from #27584.
| Repro | Zend / VM | AOT (before) |
|---|---|---|
RecursiveTreeIterator(RecursiveArrayIterator(["a"=>["b"=>1,"c"=>2]])) foreach |
\-Array| |-1| \-2| |
compile fatal: Referring to a basic block in another function |
| Parent + Multi + Tree (#27584 wrap) | Parent:b / Multi:a:1 b:2 / Tree:\-Array|… |
same verify failure when Tree is present |
Root cause (diagnosis)
RecursiveTreeIteratorBuildRuntime::emitWalk creates control-flow BBs on __compiler_rti_walk, but HashTableValuesLlvm / HashTableReadLlvm / strval append via BasicBlockHelper::append, which prefers Context::$loweringLlvmFunction (user main) over the walk insert parent — same class as #33896 (range) / #33934 (mktime).
php-src reference
- php/php-src
ext/spl/spl_iterators.c— RecursiveTreeIterator
PHP implementation target
lib/JIT/Builtin/RecursiveTreeIteratorBuildRuntime.php—BasicBlockHelper::scopeLoweringToFunctionaround walk/build emit (peer ArrayWalkLlvm / RangeIntRuntime)
Repro
./script/docker-exec.sh -- bash -lc 'php bin/compile.php -o /tmp/rti.bin test/repro/aot_recursive_tree_iterator_module_verify.php'Done when
- AOT compile succeeds; stdout matches Zend for the wrap repro
-
./script/aot-smoke.shstays 8/8 - Unit guard under
test/unit/(@group llvm/aot)
lane overflow: #32122 / #31968 children closed; no open lane-C AOT crash in queue.
Activity
PurHur commentedon Aug 22, 2026
claim: worker-lane-c — starting this run (lane overflow: #32122/#31968 children closed; open queue had no unclaimed AOT crash). Fix: scope loweringLlvmFunction onto RTI walk/build ABIs.
AOT: scope RecursiveTreeIterator walk/build onto ABI fn (#33974) (#33978
PurHur commentedon Aug 22, 2026
merged: #33978
Root cause:
RecursiveTreeIteratorBuildRuntimeemitWalk/emitBuild leftContext::$loweringLlvmFunctionon usermain, soHashTable*Llvm/strvalBBs landed in the wrong function whilerti_walk_*stayed on__compiler_rti_walk→ Module.php:180.Fix:
BasicBlockHelper::scopeLoweringToFunctionaround walk/build emit (peer #33896 / #33934).Verification:
./script/aot-smoke.sh→ 8/8./script/phpunit.sh --filter Issue33974RecursiveTreeIteratorAotTest→ OK (2 tests, 14 assertions)Tree:\-Array| |-1| \-2|)