Regression: HELPER_RUNTIME_O=0 AOT compile fails looking up __compiler_trigger_error after #33234 (lib/JIT/Builtin/Type.php)

[PurHur]

Category

Regression · Pillar 1 (Trust) · follow-up of #33234 · HELPER_RUNTIME_O=0 thin AOT

Problem

#33234 dropped the Type always-on __compiler_trigger_error empty decl/register. Ownership is StringTriggerError / JitTriggerErrorKernel, but Type::register() still calls SessionStartOptionsRuntime::ensureLinked() before any StringTriggerError::ensureLinked.

With PHP_COMPILER_HELPER_RUNTIME_O=0 (honest thin path used by DOM AOT unit tests), NestedJIT of session helpers lowers scalar coerce warnings via JitScalarEnumCoerce::emitObjectScalarWarning → lookupFunction('__compiler_trigger_error') and throws:

Unable to lookup non-existing function __compiler_trigger_error

Measured on master @ f0f17ca3a9 after ./script/aot-smoke.sh 8/8 (helper-cache path still green):

Repro	helper cache	HELPER_RUNTIME_O=0
<?php echo "hi\n";	links + prints hi	compile fail (lookup)
DOM createElement+setAttribute	ok	compile fail (lookup)

Type::initialize() early-returns for STANDALONE/EMBED before the late StringTriggerError::ensureLinked at the bottom of initialize — so thin AOT never got the late link either during Context construct.

Root cause

Stack (HELPER_O=0 hello):

Type::register → SessionStartOptionsRuntime::ensureLinked → NestedJIT → JitZendScalarCast → JitScalarEnumCoerce::emitObjectScalarWarning → Context::lookupFunction('__compiler_trigger_error')

Previously Type's always-on empty shell satisfied lookup; after #33234 the module-local owner must be linked before any NestedJIT in register().

PHP implementation target

• lib/JIT/Builtin/Type.php — StringTriggerError::ensureLinked($this->context) before SessionStartOptionsRuntime::ensureLinked in register() (keep initialize ensureLinked; no Type empty addFunction/registerFunction for the ABI)
• Unit guard in TypeDeadTriggerErrorAbiRuntimeShrinkTest (or sibling) asserting register order
• No new runtime/*.c

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && TMP=$(mktemp -d) && printf "%s\n" "<?php echo \"hi\\n\";" > "$TMP/h.php" && PHP_COMPILER_HELPER_RUNTIME_O=0 php bin/compile.php -o "$TMP/h.bin" "$TMP/h.php"'

Done when

• PHP_COMPILER_HELPER_RUNTIME_O=0 php bin/compile.php on hello-world exits 0 and binary prints hi
• Same for a minimal DOM createElement/setAttribute script
• ./script/aot-smoke.sh stays 8/8
• No Type always-on __compiler_trigger_error empty decl restored

Parent

• php-in-php: drop leftover Type always-on __compiler_trigger_error ABI shell (Zend/zend_execute_API.c) #33234 (Type shell drop)
• Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122 / Fix: AOT link fails for EVERY binary — duplicate memset declaration #31894 (.1 ABI drift class)

[PurHur]

claim: DOM/XML specialist — StringTriggerError::ensureLinked before SessionStartOptionsRuntime NestedJIT in Type::register (#33234 follow-up)

[PurHur]

claim: implementer-worker-lane-a — starting this run (lane overflow: #32122/#31968 children closed; #33248 is open release-blocker AOT compile fail; prior DOM claim has no PR/branch after several minutes; Focus=Language/AOT IR)

[PurHur]

merged: #33254

Fix: Type::register() calls StringTriggerError::ensureLinked before SessionStartOptionsRuntime::ensureLinked so HELPER_RUNTIME_O=0 NestedJIT can lookup __compiler_trigger_error (no Type always-on empty decl restored).

Verification:

• PHP_COMPILER_HELPER_RUNTIME_O=0 php bin/compile.php hello → hi (COMPILE_RC:0; was Unable to lookup / RC:2)
• DOM createElement+setAttribute thin AOT → c (COMPILE_RC:0)
• ./script/phpunit.sh --filter TypeDeadTriggerErrorAbiRuntimeShrinkTest → OK (6 tests, 29 assertions)
• ./script/aot-smoke.sh → 8 passed, 0 failed

[PurHur]

Note: PR #33254 was a duplicate of already-merged #33251; closed without merge. Issue remains closed via #33251.

[PurHur]

correction: PR #33254 did not merge — it conflicted because #33251 (f519c7cb95) already landed the same StringTriggerError::ensureLinked before SessionStartOptionsRuntime fix and closed this issue.

Lane A repro on master @ 1a2ade3186 after #33251/#33252:

• PHP_COMPILER_HELPER_RUNTIME_O=0 hello → hi (COMPILE_RC:0)
• ./script/aot-smoke.sh was 8/8 earlier this run
• AOT: link StringTriggerError before SessionStart NestedJIT (#33248) #33254 closed as duplicate/superseded