Skip to content

php-in-php: drop leftover Type always-on sprintf/printf/number_format ABI shells (ext/standard/formatted_print.c) #32921

Description

@PurHur

Category

php-in-php · trust / ABI drift · leftover of #32122 class

Problem

Builtin\Type::register still always-on addFunctions empty __compiler_sprintf / __compiler_printf / __compiler_number_format decls. NestedJIT/AOT bodies are owned by StringFormat (getNamedFunction first, then addFunction if absent; thin AOT already calls implementIfDeclared from JitSprintf / JitPrintf / JitNumberFormat). Leftover Type empty decls risk name.1 vs Runtime ABI drift (#31894 / #32122) — same class as #32897 json / #32902 xmlrpc. These symbols sit on the float→string path (#31963).

php-src reference

PHP implementation target

  • lib/JIT/Builtin/Type.php — drop always-on format ABI shells; Type::initialize ensureLinkeds StringFormat
  • Keep ownership in lib/JIT/Builtin/StringFormat.php + ext/standard/SprintfJitHelper.php

Done when

  • Type.php no longer addFunctions __compiler_sprintf / __compiler_printf / __compiler_number_format
  • AOT sprintf / printf / number_format still match Zend
  • ./script/aot-smoke.sh stays 8/8
  • Shrink unit test (peer TypeDeadXmlrpcAbiRuntimeShrinkTest)

Parent

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:compilerCompiler / CFG / JITenhancementNew feature or requestimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevEx

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions