Fix: AOT link memcpy.1 undefined — duplicate decl peers of #31894 (lib/JIT/LibcExtern.php)

[PurHur]

Category

Foundation · AOT link · sibling to #31894

Problem

#31894 fixed memset.1 duplicate declarations in GcCollectCyclesRuntime::ensureExternal(), but the same pattern remained in ObStorageLlvm, OutputRewriteVarsStorage, UrlRewriterApplyRuntime, StringSscanfByRef, StringZlibJit — each calling module->addFunction('memcpy', …) when lookupFunction() threw while LibcExtern already had memcpy in the MODULE.

Gate	Before	After fix
script/aot-smoke.sh (default helper cache)	0/8 — undefined reference to memcpy.1	8/8
php bin/compile.php -o /tmp/x test/repro/dom_xpath_relative_aot_31738.php	link fail	ok

Prelinked helper units referencing stale memcpy.1/memset.2 must be refreshed (IniJitHelper, AssertOptionsJitHelper, DomStandaloneAotInitJitHelper minimum).

php-src reference

N/A — compiler link infrastructure.

PHP implementation target

• lib/JIT/LibcExtern.php — public ensureExternalDecl() (getNamedFunction-first)
• Peer ensureExternal() helpers delegate to it
• Refresh stale prelinked/helper-runtime/ units

Repro

./script/docker-exec.sh -- bash -lc './script/aot-smoke.sh'

Done when

• aot-smoke 8/8 with committed prelinked tier (no local cache)
• DOM AOT repro dom_xpath_relative_aot_31738.php links and runs

[PurHur]

claim: PHP Compiler Ext — DOM & XML — starting this run (AOT memcpy link blocks all DOM AOT verification; sibling to #31894)

[PurHur]

Merged via PR #31911.

Fix: LibcExtern::ensureExternalDecl() (getNamedFunction-first, sibling to #31894 memset fix) + peer ObStorage/OutputRewrite/UrlRewriter/StringSscanf/StringZlib/GcCollectCycles delegates. Refreshed prelinked IniJitHelper, AssertOptionsJitHelper, DomStandaloneAotInitJitHelper units.

Verification:

rm -rf build/helper-runtime-cache && ./script/aot-smoke.sh → 8 passed, 0 failed
php bin/compile.php -o /tmp/x test/repro/dom_xpath_relative_aot_31738.php → ok
maintainer_gap_dom_contains_null_aot_31791.php AOT → 0/0

DOM/XML issue queue was empty (P0 items #19208/#19211/#19212 and recent #31738/#31791 closed). This unblocks DOM AOT verification path.