Regression: SplFileObject::fgetcsv/fputcsv separator ValueError cites fgetcsv() arg #3 — Zend method + arg index (ext/spl/spl_directory.c)

[PurHur]

Category

Regression: · php-src-strict · SplFileObject CSV separator ValueError wording

Problem

SplFileObject::fgetcsv('') / fputcsv(..., '') on Zend throw ValueError naming SplFileObject::fgetcsv(): Argument #1 ($separator) / SplFileObject::fputcsv(): Argument #2 ($separator). VM reuses the free-function fgetcsv()/fputcsv() path and cites fgetcsv(): Argument #3 ($separator) / fputcsv(): Argument #3 ($separator).

Probed 2026-08-16 — host Zend PHP 8.2.32 vs php bin/vm.php.

Repro	Zend 8.2+	VM (2026-08-16)
$o->fgetcsv('')	ValueError: SplFileObject::fgetcsv(): Argument #1 ($separator) must be a single character	ValueError: fgetcsv(): Argument #3 ($separator) …
$o->fputcsv(['x'], '')	ValueError: SplFileObject::fputcsv(): Argument #2 ($separator) …	ValueError: fputcsv(): Argument #3 ($separator) …

php-src reference

• php/php-src ext/spl/spl_directory.c — SPL_METHOD(SplFileObject, fgetcsv) / fputcsv
• Free-function wording differs because stream arg shifts indices (php-src ext/standard/file.c)

PHP implementation target

• ext/spl/ SplFileObject CSV methods — pass method-shaped function name + 1-based arg indices into shared CSV separator guard (do not hardcode free-function fgetcsv/fputcsv labels)
• PHP-in-PHP; no new runtime/*.c

Repro

./script/docker-exec.sh -- bash -lc 'php test/repro/maintainer_gap_splfileobject_csv_separator_message.php'
./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/repro/maintainer_gap_splfileobject_csv_separator_message.php'

Done when

• Empty-separator ValueError text matches Zend for both methods (method name + arg index + $separator)
• Targeted compliance/PHPUnit guard
• php-src-strict; no php-compiler-strict shortcut

[PurHur]

Queued for next advanced-stdlib SPL batch after #31539 (filed with repro).

[PurHur]

Next advanced-stdlib item after #31528/#31529/#31539. Repro landed on master via #31542 (test/repro/maintainer_gap_splfileobject_csv_separator_message.php).

[PurHur]

claim: Worker Lane B — starting this run

Lane B (31540 % 3 == 1). Behavioral SplFileObject CSV separator ValueError wording (method name + arg index), not Reflection stub / STD Lib ext/standard factory. Branch agent/issue-31540-splfileobject-csv-separator-message.

[PurHur]

Merged #31545

Verification

• Zend + php bin/vm.php on test/repro/maintainer_gap_splfileobject_csv_separator_message.php — identical method-shaped ValueError lines
• ./script/phpunit.sh --filter Issue31540SplFileObjectCsvSeparatorMessageTest → OK (2 tests)
• Free-function fgetcsv separator validation repro still ok

php-src-strict: VmCsvArg callee label + 1-based indices from SplFileObjectBuiltin (fgetcsv #1 / fputcsv #2 / setCsvControl #1).